From a26f29e7c8fcf1d022a3e2e4c5c03db8090c18ca Mon Sep 17 00:00:00 2001 From: Kasia Kucharczyk <2536609+kkucharc@users.noreply.github.com> Date: Wed, 23 Sep 2020 19:26:22 +0200 Subject: [PATCH] fix: changes a pylint check in dashboard module (#10978) * Removed not needed disabled pylint rules from `set_dash_metadata`: - `disable=too-many-locals`, - `too-many-branches`, - `too-many-statements` * Changed broad exception to KeyError. * Reverted broad_exception in get_col_type in utils --- superset/dashboards/dao.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/superset/dashboards/dao.py b/superset/dashboards/dao.py index 3cffe11f7e..bddc467dd5 100644 --- a/superset/dashboards/dao.py +++ b/superset/dashboards/dao.py @@ -81,7 +81,7 @@ class DashboardDAO(BaseDAO): raise ex @staticmethod - def set_dash_metadata( # pylint: disable=too-many-locals,too-many-branches,too-many-statements + def set_dash_metadata( dashboard: Dashboard, data: Dict[Any, Any], old_to_new_slice_ids: Optional[Dict[int, int]] = None,