diff --git a/superset-frontend/spec/javascripts/dashboard/util/newEntitiesFromDrop_spec.js b/superset-frontend/spec/javascripts/dashboard/util/newEntitiesFromDrop_spec.js index 339ab1e382..6ab80569de 100644 --- a/superset-frontend/spec/javascripts/dashboard/util/newEntitiesFromDrop_spec.js +++ b/superset-frontend/spec/javascripts/dashboard/util/newEntitiesFromDrop_spec.js @@ -94,7 +94,11 @@ describe('newEntitiesFromDrop', () => { expect(result.a.children).toHaveLength(1); expect(Object.keys(result)).toHaveLength(3); - expect(result[newRowId].type).toBe(ROW_TYPE); - expect(result[newChartId].type).toBe(CHART_TYPE); + const newRow = result[newRowId]; + expect(newRow.type).toBe(ROW_TYPE); + expect(newRow.parents).toEqual(['a']); + const newChart = result[newChartId]; + expect(newChart.type).toBe(CHART_TYPE); + expect(newChart.parents).toEqual(['a', newRowId]); }); }); diff --git a/superset-frontend/src/dashboard/util/newEntitiesFromDrop.js b/superset-frontend/src/dashboard/util/newEntitiesFromDrop.js index c0e515768b..3b3a9148eb 100644 --- a/superset-frontend/src/dashboard/util/newEntitiesFromDrop.js +++ b/superset-frontend/src/dashboard/util/newEntitiesFromDrop.js @@ -51,8 +51,8 @@ export default function newEntitiesFromDrop({ dropResult, layout }) { rowWrapper.children = [newDropChild.id]; rowWrapper.parents = (dropEntity.parents || []).concat(dropEntity.id); newEntities[rowWrapper.id] = rowWrapper; - newDropChild = rowWrapper; newDropChild.parents = rowWrapper.parents.concat(rowWrapper.id); + newDropChild = rowWrapper; } else if (dragType === TABS_TYPE) { // create a new tab component const tabChild = newComponentFactory(TAB_TYPE);