From 9fe02220092305ca8b24d4228d9ab2b6146afed6 Mon Sep 17 00:00:00 2001
From: jmistry <mistry.jaisheel@gmail.com>
Date: Wed, 26 May 2021 08:50:40 +0200
Subject: [PATCH] feat: ability to pull from your own docker registry using a
 secret (#14686)

* feature: ability to pull from your own docker registry using a secret

* feature: ability to pull from your own docker registry using a secret

* fix: formating

* fix: formating

* use secret for all deployments and jobs that use the helm chart

* update chart version number

Co-authored-by: jaisheel <jaisheel.mistry@partner.bmw.co.za>
---
 helm/superset/Chart.yaml                       | 2 +-
 helm/superset/templates/deployment-beat.yaml   | 4 ++++
 helm/superset/templates/deployment-worker.yaml | 4 ++++
 helm/superset/templates/deployment.yaml        | 5 +++++
 helm/superset/templates/init-job.yaml          | 4 ++++
 helm/superset/values.yaml                      | 3 +++
 6 files changed, 21 insertions(+), 1 deletion(-)

diff --git a/helm/superset/Chart.yaml b/helm/superset/Chart.yaml
index 4fd7f59cd8..d06eff1859 100644
--- a/helm/superset/Chart.yaml
+++ b/helm/superset/Chart.yaml
@@ -22,7 +22,7 @@ maintainers:
   - name: craig-rueda
     email: craig@craigrueda.com
     url: https://github.com/craig-rueda
-version: 0.1.2
+version: 0.1.3
 dependencies:
 - name: postgresql
   version: 10.2.0
diff --git a/helm/superset/templates/deployment-beat.yaml b/helm/superset/templates/deployment-beat.yaml
index 128bc6d767..0ec76da15e 100644
--- a/helm/superset/templates/deployment-beat.yaml
+++ b/helm/superset/templates/deployment-beat.yaml
@@ -96,6 +96,10 @@ spec:
       tolerations:
 {{ toYaml . | indent 8 }}
     {{- end }}
+{{- if .Values.imagePullSecrets }}
+      imagePullSecrets:
+{{ toYaml .Values.imagePullSecrets | indent 8 }}
+      {{- end }}
       volumes:
         - name: superset-config
           secret:
diff --git a/helm/superset/templates/deployment-worker.yaml b/helm/superset/templates/deployment-worker.yaml
index 4001e76e92..fe0ce20d85 100644
--- a/helm/superset/templates/deployment-worker.yaml
+++ b/helm/superset/templates/deployment-worker.yaml
@@ -94,6 +94,10 @@ spec:
       tolerations:
 {{ toYaml . | indent 8 }}
     {{- end }}
+{{- if .Values.imagePullSecrets }}
+      imagePullSecrets:
+{{ toYaml .Values.imagePullSecrets | indent 8 }}
+      {{- end }}
       volumes:
         - name: superset-config
           secret:
diff --git a/helm/superset/templates/deployment.yaml b/helm/superset/templates/deployment.yaml
index 2a611ca8f5..8e807daf15 100644
--- a/helm/superset/templates/deployment.yaml
+++ b/helm/superset/templates/deployment.yaml
@@ -106,6 +106,11 @@ spec:
       tolerations:
 {{ toYaml . | indent 8 }}
     {{- end }}
+{{- if .Values.imagePullSecrets }}
+      imagePullSecrets:
+{{ toYaml .Values.imagePullSecrets | indent 8 }}
+      {{- end }}
+
       volumes:
         - name: superset-config
           secret:
diff --git a/helm/superset/templates/init-job.yaml b/helm/superset/templates/init-job.yaml
index 9a4530d3c8..b3c4fd42f6 100644
--- a/helm/superset/templates/init-job.yaml
+++ b/helm/superset/templates/init-job.yaml
@@ -59,6 +59,10 @@ spec:
         command: {{  tpl (toJson .Values.init.command) . }}
         resources:
 {{ toYaml .Values.init.resources | indent 10 }}
+{{- if .Values.imagePullSecrets }}
+      imagePullSecrets:
+{{ toYaml .Values.imagePullSecrets | indent 8 }}
+      {{- end }}
       volumes:
         - name: superset-config
           secret:
diff --git a/helm/superset/values.yaml b/helm/superset/values.yaml
index 1a25419d16..58e9faaef5 100644
--- a/helm/superset/values.yaml
+++ b/helm/superset/values.yaml
@@ -106,6 +106,9 @@ image:
   tag: latest
   pullPolicy: IfNotPresent
 
+imagePullSecrets: []
+
+
 service:
   type: ClusterIP
   port: 8088