diff --git a/superset/assets/cypress/integration/explore/control.test.js b/superset/assets/cypress/integration/explore/control.test.js index 7d0da009ec..24092d173b 100644 --- a/superset/assets/cypress/integration/explore/control.test.js +++ b/superset/assets/cypress/integration/explore/control.test.js @@ -168,7 +168,7 @@ describe('AdhocFilters', () => { .trigger('mousedown') .click(); }); - + cy.get('.adhoc-filter-option').click({ force: true }); cy.get('#filter-edit-popover').within(() => { cy.get('[data-test=adhoc-filter-simple-value]').within(() => { cy.get('div.select-input').click({ force: true }); @@ -201,6 +201,7 @@ describe('AdhocFilters', () => { .click(); }); + cy.get('.adhoc-filter-option').click({ force: true }); cy.get('#filter-edit-popover').within(() => { cy.get('#adhoc-filter-edit-tabs-tab-SQL').click(); cy.get('.ace_content').click(); diff --git a/superset/assets/src/explore/components/AdhocFilterOption.jsx b/superset/assets/src/explore/components/AdhocFilterOption.jsx index 8b6adf621d..0c9ce81c1c 100644 --- a/superset/assets/src/explore/components/AdhocFilterOption.jsx +++ b/superset/assets/src/explore/components/AdhocFilterOption.jsx @@ -45,7 +45,7 @@ export default class AdhocFilterOption extends React.PureComponent { this.onPopoverResize = this.onPopoverResize.bind(this); this.onOverlayEntered = this.onOverlayEntered.bind(this); this.onOverlayExited = this.onOverlayExited.bind(this); - this.state = { overlayShown: !this.props.adhocFilter.fromFormData }; + this.state = { overlayShown: false }; } onPopoverResize() { @@ -90,7 +90,6 @@ export default class AdhocFilterOption extends React.PureComponent { overlay={overlay} rootClose shouldUpdatePosition - defaultOverlayShown={!adhocFilter.fromFormData} onEntered={this.onOverlayEntered} onExited={this.onOverlayExited} > diff --git a/superset/assets/src/explore/components/AdhocMetricOption.jsx b/superset/assets/src/explore/components/AdhocMetricOption.jsx index ae168ca416..6fdfa3f956 100644 --- a/superset/assets/src/explore/components/AdhocMetricOption.jsx +++ b/superset/assets/src/explore/components/AdhocMetricOption.jsx @@ -39,7 +39,7 @@ export default class AdhocMetricOption extends React.PureComponent { this.onOverlayEntered = this.onOverlayEntered.bind(this); this.onOverlayExited = this.onOverlayExited.bind(this); this.onPopoverResize = this.onPopoverResize.bind(this); - this.state = { overlayShown: !this.props.adhocMetric.fromFormData }; + this.state = { overlayShown: false }; } onPopoverResize() { @@ -47,7 +47,7 @@ export default class AdhocMetricOption extends React.PureComponent { } onOverlayEntered() { - this.setState({ overlayShown: true }); + this.setState({ overlayShown: false }); } onOverlayExited() {