From 9a8c3a044710bcfc578b77b498af1f15685f2bca Mon Sep 17 00:00:00 2001 From: Maxime Beauchemin Date: Wed, 8 Mar 2017 20:14:42 -0800 Subject: [PATCH] [table] metric ordering is wrong in some cases (#2373) --- superset/assets/visualizations/table.js | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/superset/assets/visualizations/table.js b/superset/assets/visualizations/table.js index 6e5392b1f5..0d642333b4 100644 --- a/superset/assets/visualizations/table.js +++ b/superset/assets/visualizations/table.js @@ -17,15 +17,10 @@ function tableVis(slice, payload) { const data = payload.data; const fd = slice.formData; + // Removing metrics (aggregates) that are strings - const realMetrics = []; let metrics = fd.metrics || []; - for (const k in data.records[0]) { - if (metrics.indexOf(k) > -1 && !isNaN(data.records[0][k])) { - realMetrics.push(k); - } - } - metrics = realMetrics; + metrics = metrics.filter(m => !isNaN(data.records[0][m])); function col(c) { const arr = [];