From 9a37ad1a1e4e44062bf753919e166e06aa80ba88 Mon Sep 17 00:00:00 2001 From: Geido <60598000+geido@users.noreply.github.com> Date: Tue, 24 Aug 2021 15:08:13 +0300 Subject: [PATCH] fix: Return original document title when leaving a dashboard (#16323) * Return original title on unmount * Name var originalDocumentTitle --- superset-frontend/src/dashboard/containers/DashboardPage.tsx | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/superset-frontend/src/dashboard/containers/DashboardPage.tsx b/superset-frontend/src/dashboard/containers/DashboardPage.tsx index d98e6ed7a1..878d2117ec 100644 --- a/superset-frontend/src/dashboard/containers/DashboardPage.tsx +++ b/superset-frontend/src/dashboard/containers/DashboardPage.tsx @@ -42,6 +42,8 @@ const DashboardContainer = React.lazy( ), ); +const originalDocumentTitle = document.title; + const DashboardPage: FC = () => { const dispatch = useDispatch(); const { addDangerToast } = useToasts(); @@ -71,6 +73,9 @@ const DashboardPage: FC = () => { if (dashboard_title) { document.title = dashboard_title; } + return () => { + document.title = originalDocumentTitle; + }; }, [dashboard_title]); useEffect(() => {