From 930353286f6f2586ebd232a0add1fde4db466e03 Mon Sep 17 00:00:00 2001
From: Kim Truong <47833996+khtruong@users.noreply.github.com>
Date: Mon, 16 Dec 2019 23:27:06 -0800
Subject: [PATCH] fix: add default value to log param in sql_json (#8851)

* fix: add default params to log

* fix: add optional typing

* fix: linting
---
 superset/views/core.py | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/superset/views/core.py b/superset/views/core.py
index 81314ff8a6..7e9fe7a2fd 100755
--- a/superset/views/core.py
+++ b/superset/views/core.py
@@ -2444,7 +2444,7 @@ class Superset(BaseSupersetView):
         rendered_query: str,
         query: Query,
         expand_data: bool,
-        log_params: Dict[str, Any],
+        log_params: Optional[Dict[str, Any]] = None,
     ) -> str:
         """
             Send SQL JSON query to celery workers
@@ -2495,7 +2495,7 @@ class Superset(BaseSupersetView):
         rendered_query: str,
         query: Query,
         expand_data: bool,
-        log_params: Dict[str, Any],
+        log_params: Optional[Dict[str, Any]] = None,
     ) -> str:
         """
             Execute SQL query (sql json)
@@ -2541,11 +2541,13 @@ class Superset(BaseSupersetView):
     @event_logger.log_this
     def sql_json(self):
         log_params = {
-            "USER_AGENT": cast(Optional[str], request.headers.get("USER_AGENT"))
+            "user_agent": cast(Optional[str], request.headers.get("USER_AGENT"))
         }
         return self.sql_json_exec(request.json, log_params)
 
-    def sql_json_exec(self, query_params: dict, log_params: dict):
+    def sql_json_exec(
+        self, query_params: dict, log_params: Optional[Dict[str, Any]] = None
+    ):
         """Runs arbitrary sql and returns data as json"""
         # Collect Values
         database_id: int = cast(int, query_params.get("database_id"))