From 8bbbd6f03fbd7fccf457706d942f114b7abb682d Mon Sep 17 00:00:00 2001 From: Yongjie Zhao Date: Tue, 21 Jun 2022 20:37:51 +0800 Subject: [PATCH] fix: should raise exception when apply a categorical axis (#20451) --- superset/common/query_context_processor.py | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/superset/common/query_context_processor.py b/superset/common/query_context_processor.py index 003c174c2a..8078868493 100644 --- a/superset/common/query_context_processor.py +++ b/superset/common/query_context_processor.py @@ -322,6 +322,16 @@ class QueryContextProcessor: # multi-dimensional charts granularity = query_object.granularity index = granularity if granularity in df.columns else DTTM_ALIAS + if not pd.api.types.is_datetime64_any_dtype( + offset_metrics_df.get(index) + ): + raise QueryObjectValidationError( + _( + "A time column must be specified " + "when using a Time Comparison." + ) + ) + offset_metrics_df[index] = offset_metrics_df[index] - DateOffset( **normalize_time_delta(offset) )