From 86eedab4d0d33bfa6ee37db3cd72dfec28f28208 Mon Sep 17 00:00:00 2001
From: Evan Rusackas <evan@preset.io>
Date: Sun, 16 Aug 2020 21:31:55 -0700
Subject: [PATCH] feat: logger supports console.table, with console.log
 fallback (#738)

* feat: logger.table

* applying Jesse's feedback

* missed a method
---
 .../superset-ui-core/src/utils/logging.ts     | 21 ++++++++++++-------
 .../test/utils/logging.test.ts                |  4 ++++
 2 files changed, 18 insertions(+), 7 deletions(-)

diff --git a/superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-core/src/utils/logging.ts b/superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-core/src/utils/logging.ts
index c4f2a23345..929c4d0fb9 100644
--- a/superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-core/src/utils/logging.ts
+++ b/superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-core/src/utils/logging.ts
@@ -16,16 +16,23 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-const logger = window.console || {
-  debug() {},
-  log() {},
-  info() {},
-  warn() {},
-  error() {},
-  trace() {},
+
+const console = window.console || {};
+const log = console.log || (() => {});
+
+const logger = {
+  log,
+  debug: console.debug || log,
+  info: console.info || log,
+  warn: console.warn || log,
+  error: console.error || log,
+  trace: console.trace || log,
+  table: console.table || log,
 };
 
 /**
  * Superset frontend logger, currently just an alias to console.
+ * This may be extended to support numerous console operations safely
+ * i.e.: https://developer.mozilla.org/en-US/docs/Web/API/Console
  */
 export default logger;
diff --git a/superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-core/test/utils/logging.test.ts b/superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-core/test/utils/logging.test.ts
index 2d4ff781f9..3707977d07 100644
--- a/superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-core/test/utils/logging.test.ts
+++ b/superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-core/test/utils/logging.test.ts
@@ -55,6 +55,10 @@ describe('logging', () => {
       logging.warn('warn');
       logging.error('error');
       logging.trace();
+      logging.table([
+        [1, 2],
+        [3, 4],
+      ]);
     }).not.toThrow();
   });
 });