From 813ed6018d4e4a6886a27e01b7d31dc422185a8d Mon Sep 17 00:00:00 2001 From: Rogan Date: Fri, 18 Aug 2017 13:18:32 +0800 Subject: [PATCH] Unnecessary to specify order_columns for DatasourceModelView (#3331) --- superset/connectors/druid/views.py | 2 -- superset/connectors/sqla/views.py | 2 -- 2 files changed, 4 deletions(-) diff --git a/superset/connectors/druid/views.py b/superset/connectors/druid/views.py index b85e611a2c..a06bc391ff 100644 --- a/superset/connectors/druid/views.py +++ b/superset/connectors/druid/views.py @@ -178,8 +178,6 @@ class DruidDatasourceModelView(DatasourceModelView, DeleteMixin): # noqa list_widget = ListWidgetWithCheckboxes list_columns = [ 'datasource_link', 'cluster', 'changed_by_', 'modified'] - order_columns = [ - 'datasource_link', 'changed_on_', 'offset'] related_views = [DruidColumnInlineView, DruidMetricInlineView] edit_columns = [ 'datasource_name', 'cluster', 'slices', 'description', 'owner', diff --git a/superset/connectors/sqla/views.py b/superset/connectors/sqla/views.py index 21529b10fc..c49d4d02a5 100644 --- a/superset/connectors/sqla/views.py +++ b/superset/connectors/sqla/views.py @@ -160,8 +160,6 @@ class TableModelView(DatasourceModelView, DeleteMixin): # noqa list_columns = [ 'link', 'database', 'changed_by_', 'modified'] - order_columns = [ - 'link', 'database', 'changed_on_'] add_columns = ['database', 'schema', 'table_name'] edit_columns = [ 'table_name', 'sql', 'filter_select_enabled', 'slices',