From 80c39daa85c9be9e66a2e3cf2c9e2a8e5a74a8d6 Mon Sep 17 00:00:00 2001 From: Yongjie Zhao Date: Wed, 1 Sep 2021 06:52:10 +0100 Subject: [PATCH] fix: can't drop column when name overlap (#16482) --- .../controls/DndColumnSelectControl/utils/optionSelector.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/superset-frontend/src/explore/components/controls/DndColumnSelectControl/utils/optionSelector.ts b/superset-frontend/src/explore/components/controls/DndColumnSelectControl/utils/optionSelector.ts index 6000d57039..4d0d76a641 100644 --- a/superset-frontend/src/explore/components/controls/DndColumnSelectControl/utils/optionSelector.ts +++ b/superset-frontend/src/explore/components/controls/DndColumnSelectControl/utils/optionSelector.ts @@ -64,7 +64,7 @@ export class OptionSelector { } has(value: string): boolean { - return !!this.getValues()?.includes(value); + return ensureIsArray(this.getValues()).includes(value); } getValues(): string[] | string | undefined {