From 79e8d77accfed4532f17712ef627288b83f7c4b9 Mon Sep 17 00:00:00 2001
From: Maxime Beauchemin <maximebeauchemin@gmail.com>
Date: Tue, 10 Aug 2021 02:09:40 -0700
Subject: [PATCH] chore: remove TerserPlugin step for build (#16163)

---
 Dockerfile                          | 2 +-
 superset-frontend/package-lock.json | 1 -
 superset-frontend/package.json      | 1 -
 superset-frontend/webpack.config.js | 9 ---------
 4 files changed, 1 insertion(+), 12 deletions(-)

diff --git a/Dockerfile b/Dockerfile
index 6ca89e889f..c73e6cad61 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -64,7 +64,7 @@ RUN /frontend-mem-nag.sh \
 
 # Next, copy in the rest and let webpack do its thing
 COPY ./superset-frontend /app/superset-frontend
-# This is BY FAR the most expensive step (thanks Terser!)
+# This seems to be the most expensive step
 RUN cd /app/superset-frontend \
         && npm run ${BUILD_CMD} \
         && rm -rf node_modules
diff --git a/superset-frontend/package-lock.json b/superset-frontend/package-lock.json
index 51d88149d5..e75cf48fd2 100644
--- a/superset-frontend/package-lock.json
+++ b/superset-frontend/package-lock.json
@@ -247,7 +247,6 @@
         "storybook-addon-jsx": "^7.3.3",
         "storybook-addon-paddings": "^3.2.0",
         "style-loader": "^1.0.0",
-        "terser-webpack-plugin": "^1.1.0",
         "thread-loader": "^1.2.0",
         "transform-loader": "^0.2.3",
         "ts-jest": "^26.4.2",
diff --git a/superset-frontend/package.json b/superset-frontend/package.json
index a96ccedf7d..b025107c6e 100644
--- a/superset-frontend/package.json
+++ b/superset-frontend/package.json
@@ -299,7 +299,6 @@
     "storybook-addon-jsx": "^7.3.3",
     "storybook-addon-paddings": "^3.2.0",
     "style-loader": "^1.0.0",
-    "terser-webpack-plugin": "^1.1.0",
     "thread-loader": "^1.2.0",
     "transform-loader": "^0.2.3",
     "ts-jest": "^26.4.2",
diff --git a/superset-frontend/webpack.config.js b/superset-frontend/webpack.config.js
index d84646cd10..327f6ac627 100644
--- a/superset-frontend/webpack.config.js
+++ b/superset-frontend/webpack.config.js
@@ -27,7 +27,6 @@ const HtmlWebpackPlugin = require('html-webpack-plugin');
 const MiniCssExtractPlugin = require('mini-css-extract-plugin');
 const OptimizeCSSAssetsPlugin = require('optimize-css-assets-webpack-plugin');
 const SpeedMeasurePlugin = require('speed-measure-webpack-plugin');
-const TerserPlugin = require('terser-webpack-plugin');
 const ManifestPlugin = require('webpack-manifest-plugin');
 const ForkTsCheckerWebpackPlugin = require('fork-ts-checker-webpack-plugin');
 const parsedArgs = require('yargs').argv;
@@ -508,14 +507,6 @@ if (isDevMode) {
   if (hasSymlink) {
     console.log(''); // pure cosmetic new line
   }
-} else {
-  config.optimization.minimizer = [
-    new TerserPlugin({
-      cache: '.terser-plugin-cache/',
-      parallel: true,
-      extractComments: true,
-    }),
-  ];
 }
 
 // Bundle analyzer is disabled by default