diff --git a/CHANGELOG.md b/CHANGELOG.md index 304b3341ed..64f1ade0ef 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -18,125 +18,835 @@ under the License. --> ## Change Log -### 0.29.0rc8 (2019/01/29 21:37:21 +00:00) -- [#6765](https://github.com/apache/incubator-superset/pull/6765) [fix] `pandas`>=0.24.0 datetimelike API changes (#6765)(@zihengCat) +### 0.34.0 (2019/08/09 00:58 +00:00) +- [#7997](https://github.com/apache/incubator-superset/pull/7997) Event logger config takes instance instead of class (#7997) (@DiggidyDave) +- [#8006](https://github.com/apache/incubator-superset/pull/8006) Local config no longer fails to import silently (#8006) (@DiggidyDave) +- [#8002](https://github.com/apache/incubator-superset/pull/8002) [SQLLab] Fix, database api unlimited page size v2 (#8002) (@dpgaspar) +- [#7999](https://github.com/apache/incubator-superset/pull/7999) Setup FOSSA as part of CI (#7999) (@mistercrunch) +- [#7949](https://github.com/apache/incubator-superset/pull/7949) Update to fix the broken blueprints link (#7949) (@mmutiso) +- [#7981](https://github.com/apache/incubator-superset/pull/7981) Fix Pandas 0.24 DateOffset bug pt. 2 (#7981) (@villebro) +- [#7993](https://github.com/apache/incubator-superset/pull/7993) [Jinja] Make Presto template functions backwards compatible (#7993) (@etr2460) +- [#7998](https://github.com/apache/incubator-superset/pull/7998) [fix] reduce content in sql lab localStorage (#7998) (@graceguo-supercat) +- [#7985](https://github.com/apache/incubator-superset/pull/7985) Fix #7984 (#7985) (@mistercrunch) +- [#7986](https://github.com/apache/incubator-superset/pull/7986) Revert "Bump FAB to 2.1.8 (#7986)" (#7996) (@etr2460) +- [#7987](https://github.com/apache/incubator-superset/pull/7987) Revert "[database] Fix, Removes the limit for the page size (#7987)" (#7995) (@etr2460) +- [#7994](https://github.com/apache/incubator-superset/pull/7994) Bump nvd3 charts for tooltip fix (#7994) (@etr2460) +- [#7992](https://github.com/apache/incubator-superset/pull/7992) [init] Setting up cache before registering blueprints (#7992) (@john-bodley) +- [#7989](https://github.com/apache/incubator-superset/pull/7989) Bump @superset-ui versions (#7989) (@kristw) +- [#7987](https://github.com/apache/incubator-superset/pull/7987) [database] Fix, Removes the limit for the page size (#7987) (@dpgaspar) +- [#7986](https://github.com/apache/incubator-superset/pull/7986) Bump FAB to 2.1.8 (#7986) (@dpgaspar) +- [#7988](https://github.com/apache/incubator-superset/pull/7988) [flake8] Ignoring I202 (#7988) (@john-bodley) +- [#7977](https://github.com/apache/incubator-superset/pull/7977) [DB Engine] Support old and new Presto syntax (#7977) (@etr2460) +- [#7952](https://github.com/apache/incubator-superset/pull/7952) [security] Adding docstrings and type hints (#7952) (@john-bodley) +- [#7963](https://github.com/apache/incubator-superset/pull/7963) Remove collation info from MSSQL column type (#7963) (@villebro) +- [#7973](https://github.com/apache/incubator-superset/pull/7973) Bump sqlparse to 0.3.0 (#7973) (@villebro) +- [#7975](https://github.com/apache/incubator-superset/pull/7975) Fix for new Pandas API (#7975) (@betodealmeida) +- [#7643](https://github.com/apache/incubator-superset/pull/7643) 7620: Start removing dependencies on requests (#7643) (@sturmer) +- [#7965](https://github.com/apache/incubator-superset/pull/7965) Bump python requirements file (#7965) (@villebro) +- [#7964](https://github.com/apache/incubator-superset/pull/7964) Use python3 for black to support py>=3.6 (#7964) (@villebro) +- [#7955](https://github.com/apache/incubator-superset/pull/7955) Fix createDatasource (#7955) (@betodealmeida) +- [#7858](https://github.com/apache/incubator-superset/pull/7858) [fix] Isolate and improve performance on tagging system (#7858) (@betodealmeida) +- [#7943](https://github.com/apache/incubator-superset/pull/7943) Update .travis.yml (#7943) (@john-bodley) +- [#7932](https://github.com/apache/incubator-superset/pull/7932) Bump nvd3 chart plugin (#7932) (@etr2460) +- [#7924](https://github.com/apache/incubator-superset/pull/7924) [fix] bug on FixedOrMetricControl component causing issues with deck.gl polygon height + deck.gl scatter radius controls (#7924) (@thunter009) +- [#7935](https://github.com/apache/incubator-superset/pull/7935) [feature flag] Enforce csrf protection on explore_json endpoint (#7935) (@graceguo-supercat) +- [#7940](https://github.com/apache/incubator-superset/pull/7940) fixing error related to install codecove in travis (#7940) (@blcksrx) +- [#7933](https://github.com/apache/incubator-superset/pull/7933) [revert] Partial revert of #7888 (#7933) (@john-bodley) +- [#7918](https://github.com/apache/incubator-superset/pull/7918) [cli] New, command line option to create or set a db URI (#7918) (@dpgaspar) +- [#7926](https://github.com/apache/incubator-superset/pull/7926) Fix #7130 - SQL Lab table name autocomplete (#7926) (@mistercrunch) +- [#7920](https://github.com/apache/incubator-superset/pull/7920) [log] Disable Log view when FAB security views are disabled (#7920) (@dpgaspar) +- [#7930](https://github.com/apache/incubator-superset/pull/7930) [sqllab] Fix, #7928 query async not working (#7930) (@dpgaspar) +- [#7931](https://github.com/apache/incubator-superset/pull/7931) Fixing the build after travis upgraded Ubuntu (#7931) (@mistercrunch) +- [#7895](https://github.com/apache/incubator-superset/pull/7895) [dashboard] fix chart showing loading icon when filter updated immuned fields (#7895) (@graceguo-supercat) +- [#7864](https://github.com/apache/incubator-superset/pull/7864) [Profile] Fix 5xx when user not found (#7864) (@etr2460) +- [#7912](https://github.com/apache/incubator-superset/pull/7912) [sqllab] Fix limit parsing bug when using limit-offset comma notation (#7912) (@villebro) +- [#7896](https://github.com/apache/incubator-superset/pull/7896) [Bugfix] Remove prequery properties from query_obj (#7896) (@villebro) +- [#7892](https://github.com/apache/incubator-superset/pull/7892) Fix incorrect datasource_name in dashboard export (#7892) (@smacker) +- [#7894](https://github.com/apache/incubator-superset/pull/7894) Set owner to dashboards and charts on import (#7894) (@smacker) +- [#7665](https://github.com/apache/incubator-superset/pull/7665) [api] [database] New, migrate to new FAB API side by side (#7665) (@dpgaspar) +- [#7880](https://github.com/apache/incubator-superset/pull/7880) [migration] add unique constraint on dashboard_slices table (#7880) (@graceguo-supercat) +- [#7915](https://github.com/apache/incubator-superset/pull/7915) Bump nvd3 charts for responsive y axis fix (#7915) (@etr2460) +- [#7868](https://github.com/apache/incubator-superset/pull/7868) [SQL Lab] Fix TableSelector perf for large option sets (#7868) (@etr2460) +- [#7907](https://github.com/apache/incubator-superset/pull/7907) [Bugfix] Response header and response mismatch on explore result from sqllab (#7907) (@arpit-agarwal) +- [#7816](https://github.com/apache/incubator-superset/pull/7816) Add cache_key_wrapper to Jinja template processor (#7816) (@villebro) +- [#7898](https://github.com/apache/incubator-superset/pull/7898) [test] Fix test data remove slice_name (#7898) (@graceguo-supercat) +- [#7897](https://github.com/apache/incubator-superset/pull/7897) [fix] Adding space after -- for SQL comments (#7897) (@john-bodley) +- [#7744](https://github.com/apache/incubator-superset/pull/7744) Fix missing `gevent` extra dependency in Docker setup (#7744) (@bmfs) +- [#7888](https://github.com/apache/incubator-superset/pull/7888) [sqla] Adding check for invalid filter columns (#7888) (@john-bodley) +- [#7883](https://github.com/apache/incubator-superset/pull/7883) Sort dashboards exported json (#7883) (@smacker) +- [#7879](https://github.com/apache/incubator-superset/pull/7879) Remove unnecessary fields from dashboard exported json (#7879) (@smacker) +- [#7882](https://github.com/apache/incubator-superset/pull/7882) Corrected ISO codes on India Country Map (#7882) (@TheLastSultan) +- [#7881](https://github.com/apache/incubator-superset/pull/7881) [sql lab] improve TableElement controls (#7881) (@mistercrunch) +- [#7773](https://github.com/apache/incubator-superset/pull/7773) Improve examples & related tests (#7773) (@mistercrunch) +- [#7877](https://github.com/apache/incubator-superset/pull/7877) Avoid removing custom sql adhoc metric when columns change (#7877) (@michellethomas) +- [#7827](https://github.com/apache/incubator-superset/pull/7827) Fix docker configurations and docker installation guide. (#7827) (@ali-bahjati) +- [#7863](https://github.com/apache/incubator-superset/pull/7863) DruidEngineSpec: set allows_subquery to True (#7863) (@michalmisiewicz) +- [#7878](https://github.com/apache/incubator-superset/pull/7878) fix: add check to re-render only if underlying layers change (#7878) (@thunter009) +- [#7875](https://github.com/apache/incubator-superset/pull/7875) bug fix for all_database_access() call (#7875) (@rahul-rahul-sp) +- [#7872](https://github.com/apache/incubator-superset/pull/7872) [docs] Advise about celery 4.3.0 requirement on redis (#7872) (@dpgaspar) +- [#7853](https://github.com/apache/incubator-superset/pull/7853) [cypress] Disable chromeWebSecurity globally (#7853) (@graceguo-supercat) +- [#7852](https://github.com/apache/incubator-superset/pull/7852) Bump pandas to 0.24 (#7852) (@villebro) +- [#7866](https://github.com/apache/incubator-superset/pull/7866) [wip] fix: multi deck.gl bug fixes (pt 2) (#7866) (@thunter009) +- [#7867](https://github.com/apache/incubator-superset/pull/7867) Update tox.ini (#7867) (@john-bodley) +- [#7856](https://github.com/apache/incubator-superset/pull/7856) Adds the ability to replace/extend caching backend (#7856) (@robdiciuccio) +- [#7854](https://github.com/apache/incubator-superset/pull/7854) fix: multi deck.gl bug fixes (#7854) (@thunter009) +- [#7845](https://github.com/apache/incubator-superset/pull/7845) Make SHOW_STACKTRACE config apply across the board (#7845) (@mistercrunch) +- [#7848](https://github.com/apache/incubator-superset/pull/7848) [celery] Bump celery to 4.3.0 (#7848) (@dpgaspar) +- [#7850](https://github.com/apache/incubator-superset/pull/7850) Update down_revision to fix migrations (#7850) (@1AB9502) +- [#7843](https://github.com/apache/incubator-superset/pull/7843) Quick fix (#7843) (@betodealmeida) +- [#4725](https://github.com/apache/incubator-superset/pull/4725) Add "Published" feature to dashboards (#4725) (@Tresdon) +- [#7835](https://github.com/apache/incubator-superset/pull/7835) Update requirements.txt (#7835) (@john-bodley) +- [#7728](https://github.com/apache/incubator-superset/pull/7728) * hacky string coercion to fix bug in cli datasource export (#7728) (@Aylr) +- [#7717](https://github.com/apache/incubator-superset/pull/7717) Refactor testconn to use get_sqla_engine (#7717) (@thoralf-gutierrez) +- [#7837](https://github.com/apache/incubator-superset/pull/7837) Updating superset-ui/legacy-preset-chart-nvd3 to 0.10.35 (#7837) (@michellethomas) +- [#7830](https://github.com/apache/incubator-superset/pull/7830) Set up a few more pre-commit hook (#7830) (@mistercrunch) +- [#7705](https://github.com/apache/incubator-superset/pull/7705) [log] New, make action log configurable and generic (#7705) (@dpgaspar) +- [#7832](https://github.com/apache/incubator-superset/pull/7832) Bump FAB to 2.1.6 (#7832) (@dpgaspar) +- [#7817](https://github.com/apache/incubator-superset/pull/7817) Add missing 'babies.png' image (#7817) (@mistercrunch) +- [#7376](https://github.com/apache/incubator-superset/pull/7376) Fixing the examples (#7376) (@mistercrunch) +- [#7821](https://github.com/apache/incubator-superset/pull/7821) Add source{d} to user list in README.md (#7821) (@marnovo) +- [#7539](https://github.com/apache/incubator-superset/pull/7539) Improvements related to ASF release process (#7539) (@mistercrunch) +- [#7747](https://github.com/apache/incubator-superset/pull/7747) fix: unicode word cloud example (#7747) (@mistercrunch) +- [#7796](https://github.com/apache/incubator-superset/pull/7796) Added possibility to translate the phrase 'No results found' in FilterBox (#7796) (@dserkowski) +- [#7621](https://github.com/apache/incubator-superset/pull/7621) fix: Better error message for dashboard import (#7621) (@smacker) +- [#7812](https://github.com/apache/incubator-superset/pull/7812) [dashboard] Fix URLShortLinkButton position after click anchor link (#7812) (@graceguo-supercat) +- [#7653](https://github.com/apache/incubator-superset/pull/7653) [schema] Deprecating the table_columns.database_expression column (#7653) (@john-bodley) +- [#7810](https://github.com/apache/incubator-superset/pull/7810) Add second and minute grains (#7810) (@villebro) +- [#7813](https://github.com/apache/incubator-superset/pull/7813) Improve documentation (#7813) (@villebro) +- [#7799](https://github.com/apache/incubator-superset/pull/7799) [fix] Updating Pandas resample logic (#7799) (@john-bodley) +- [#7502](https://github.com/apache/incubator-superset/pull/7502) Add Table List Refresh Button (#7502) (@MarcusSorealheis) +- [#7809](https://github.com/apache/incubator-superset/pull/7809) [travis] Adding Black tox environment (#7809) (@john-bodley) +- [#7325](https://github.com/apache/incubator-superset/pull/7325) [Viz] transpose pivot table (#7325) (@zhaoyongjie) +- [#7435](https://github.com/apache/incubator-superset/pull/7435) Update messages.json (#7435) (@JesusEkie) +- [#7770](https://github.com/apache/incubator-superset/pull/7770) Autocomplete in the table browser in SQL lab is broken - Fix part 2 (#7770) (@khtruong) +- [#7755](https://github.com/apache/incubator-superset/pull/7755) [fix] Handling of non-existent datasource (#7755) (@john-bodley) +- [#7791](https://github.com/apache/incubator-superset/pull/7791) Improve performance for add slice container (#7791) (@etr2460) +- [#7801](https://github.com/apache/incubator-superset/pull/7801) add new user (#7801) (@pokyu) +- [#7777](https://github.com/apache/incubator-superset/pull/7777) Truncate data that is expanded (#7777) (@betodealmeida) +- [#7783](https://github.com/apache/incubator-superset/pull/7783) [SQL Lab] Add hard time limit fallback for async queries (#7783) (@etr2460) +- [#7788](https://github.com/apache/incubator-superset/pull/7788) Fix SQL editor tooltip to not cut off long column names (#7788) (@cguan7) +- [#7467](https://github.com/apache/incubator-superset/pull/7467) Change kv content-type to text/plain (#7467) (@rahul-rahul-sp) +- [#7787](https://github.com/apache/incubator-superset/pull/7787) Updating legacy-plugin-chart-heatmap to fix an issue with heatmap (#7787) (@michellethomas) +- [#7782](https://github.com/apache/incubator-superset/pull/7782) feat: query based on all partitions (#7782) (@khtruong) +- [#7767](https://github.com/apache/incubator-superset/pull/7767) bugfix: Oracle timegrains fail to render when wrapped in outer query (#7767) (@villebro) +- [#7769](https://github.com/apache/incubator-superset/pull/7769) [format] Using Black (#7769) (@john-bodley) +- [#7753](https://github.com/apache/incubator-superset/pull/7753) [testconn] Fixing response (#7753) (@john-bodley) +- [#7764](https://github.com/apache/incubator-superset/pull/7764) Show generic error msg and hide stacktrace if feature flag is enabled (#7764) (@rahul-rahul-sp) +- [#7605](https://github.com/apache/incubator-superset/pull/7605) chore: taking db dependencies out of requirements-dev.txt (#7605) (@mistercrunch) +- [#7749](https://github.com/apache/incubator-superset/pull/7749) Fix deck.gl sample charts with js (#7749) (@villebro) +- [#7011](https://github.com/apache/incubator-superset/pull/7011) fix(filterbox): fixed runtime exception in filterbox for allow multiple selection is false (#7011) (@jitendra-kumawat) +- [#7756](https://github.com/apache/incubator-superset/pull/7756) Add csv upload support for BigQuery (#7756) (@villebro) +- [#7724](https://github.com/apache/incubator-superset/pull/7724) [security] [ui] Make security views use superset's list widget (#7724) (@dpgaspar) +- [#7750](https://github.com/apache/incubator-superset/pull/7750) Bump FAB to 2.1.5 (#7750) (@dpgaspar) +- [#7720](https://github.com/apache/incubator-superset/pull/7720) [SQL Lab] Add JSON modal when clicking on cells with JSON objects (#7720) (@etr2460) +- [#7745](https://github.com/apache/incubator-superset/pull/7745) [fix] Force refresh table list broken (#7745) (@betodealmeida) +- [#7736](https://github.com/apache/incubator-superset/pull/7736) Revert "Autocomplete in the table browser in SQL lab is broken (#7736)" (#7743) (@khtruong) +- [#7736](https://github.com/apache/incubator-superset/pull/7736) Autocomplete in the table browser in SQL lab is broken (#7736) (@khtruong) +- [#7646](https://github.com/apache/incubator-superset/pull/7646) compile column names (#7646) (@villebro) +- [#7722](https://github.com/apache/incubator-superset/pull/7722) [SQL Lab] Polish side pane animation (#7722) (@etr2460) +- [#7616](https://github.com/apache/incubator-superset/pull/7616) Fixing time comparison to look for past deltas (#7616) (@michellethomas) +- [#7729](https://github.com/apache/incubator-superset/pull/7729) Bump sqla to 1.3.5 (#7729) (@villebro) +- [#7652](https://github.com/apache/incubator-superset/pull/7652) Allowing withVerification to remove all options if none are valid (#7652) (@michellethomas) +- [#7679](https://github.com/apache/incubator-superset/pull/7679) css: add margin-top to ResultSet (#7679) (@mistercrunch) +- [#7723](https://github.com/apache/incubator-superset/pull/7723) [CSV Upload] Fix Index Column input filter (#7723) (@etr2460) +- [#7700](https://github.com/apache/incubator-superset/pull/7700) [dashboard] fix nested tab component visible logic (#7700) (@graceguo-supercat) +- [#7709](https://github.com/apache/incubator-superset/pull/7709) [docker] Fix docker-init missing FLASK_APP (#7709) (@dpgaspar) +- [#7701](https://github.com/apache/incubator-superset/pull/7701) Update @superset-ui/legacy-preset-chart-nvd3 (#7701) (@etr2460) +- [#7696](https://github.com/apache/incubator-superset/pull/7696) [docs] Fix, flask fab cli does not need app parameter (#7696) (@dpgaspar) +- [#7691](https://github.com/apache/incubator-superset/pull/7691) [SQL Lab] Fix proptypes warning (#7691) (@etr2460) +- [#7693](https://github.com/apache/incubator-superset/pull/7693) Render columns dynamically on wide tables (#7693) (@betodealmeida) +- [#7687](https://github.com/apache/incubator-superset/pull/7687) Add Intercom to Superset users (#7687) (@kate-gallo) +- [#7688](https://github.com/apache/incubator-superset/pull/7688) Adding 6play as users (#7688) (@CoryChaplin) +- [#7667](https://github.com/apache/incubator-superset/pull/7667) [epoch] Remove non-UTC epoch logic (#7667) (@john-bodley) +- [#7672](https://github.com/apache/incubator-superset/pull/7672) Update index.rst (#7672) (@john-bodley) +- [#7678](https://github.com/apache/incubator-superset/pull/7678) Revert "Allow bigint to be used as time column in Presto" #7670 (#7678) (@john-bodley) +- [#7073](https://github.com/apache/incubator-superset/pull/7073) [connectors] Make cluster/database and datasource/table unselectable in CRUD view (#7073) (@john-bodley) +- [#7598](https://github.com/apache/incubator-superset/pull/7598) adding command for seeing changes reflected. (#7598) (@MarcusSorealheis) +- [#7478](https://github.com/apache/incubator-superset/pull/7478) Bump FAB to 2.1.4 (#7478) (@dpgaspar) +- [#7526](https://github.com/apache/incubator-superset/pull/7526) Fixed SQL Lab Query Search scrolling issue(#7526) (#7674) (@rusackas) +- [#7676](https://github.com/apache/incubator-superset/pull/7676) Break up db_engine_specs (#7676) (@villebro) +- [#7392](https://github.com/apache/incubator-superset/pull/7392) Remove duplicate paragraph in celery tasks documentation (#7392) (@thoralf-gutierrez) +- [#7567](https://github.com/apache/incubator-superset/pull/7567) Add epoch funcs for BigQuery (#7567) (@villebro) +- [#7641](https://github.com/apache/incubator-superset/pull/7641) [SQL Lab] Clarify SQL Lab query and display limits (#7641) (@etr2460) +- [#7642](https://github.com/apache/incubator-superset/pull/7642) [dashboard] pass dashboard filters to share chart url in dropdown (#7642) (@graceguo-supercat) +- [#7572](https://github.com/apache/incubator-superset/pull/7572) [SQL Lab] Show warning when user used up localStorage (#7572) (@graceguo-supercat) +- [#7610](https://github.com/apache/incubator-superset/pull/7610) docs: Add Tenable to the List of Users (#7610) (@dflionis) +- [#7475](https://github.com/apache/incubator-superset/pull/7475) Apply DashboardFilter to the dashboards in SliceModeView (#7475) (@rahul-rahul-sp) +- [#7638](https://github.com/apache/incubator-superset/pull/7638) Add new escape characters to OnPasteSelect (#7638) (@1AB9502) +- [#7660](https://github.com/apache/incubator-superset/pull/7660) [docs] Fix, deprecate fabmanager cli (#7660) (@dpgaspar) +- [#5096](https://github.com/apache/incubator-superset/pull/5096) Revert "Boxplot should not require a datetime column (#5096)" (#7655) (@khtruong) +- [#7175](https://github.com/apache/incubator-superset/pull/7175) [SQL Lab] CTAS now uses the right async configuration (#7175) (@enricoberti) +- [#7647](https://github.com/apache/incubator-superset/pull/7647) [Profile] Fix react gravitar size prop type warning (#7647) (@etr2460) +- [#7618](https://github.com/apache/incubator-superset/pull/7618) Add Filter on DatabaseView that filters DBs Based on Role Access (#7618) (@dflionis) +- [#7640](https://github.com/apache/incubator-superset/pull/7640) [dashboard] click tab anchor link (#7640) (@graceguo-supercat) +- [#7632](https://github.com/apache/incubator-superset/pull/7632) Fix colors in ellipsis (#7632) (@betodealmeida) +- [#7433](https://github.com/apache/incubator-superset/pull/7433) Adding codecov targets and thresholds (#7433) (@michellethomas) +- [#7490](https://github.com/apache/incubator-superset/pull/7490) [fix] SQL parsing of table names (#7490) (@john-bodley) +- [#7494](https://github.com/apache/incubator-superset/pull/7494) make filter_values() macro to properly accept value from filter box with single value setting (#7494) (@jimhorng) +- [#7606](https://github.com/apache/incubator-superset/pull/7606) fix: SqlaColumn.type overflow on mysql (#7606) (@mistercrunch) +- [#7636](https://github.com/apache/incubator-superset/pull/7636) [query] Fix, remove not possible to order columns (#7636) (@dpgaspar) +- [#7635](https://github.com/apache/incubator-superset/pull/7635) Fixed Time Grain and Added Drill to README (#7635) (@cgivre) +- [#7593](https://github.com/apache/incubator-superset/pull/7593) fix: address issue #7458 (#7593) (@mistercrunch) +- [#7561](https://github.com/apache/incubator-superset/pull/7561) [FAB] set AppBuilder to update_perms=False (#7561) (@mistercrunch) +- [#7575](https://github.com/apache/incubator-superset/pull/7575) Alternative fix for #7559 (#7575) (@mistercrunch) +- [#7633](https://github.com/apache/incubator-superset/pull/7633) Wrapping up #7130 (#7633) (@mistercrunch) +- [#7617](https://github.com/apache/incubator-superset/pull/7617) Allow trailing spaces in simple filter values (#7617) (@etr2460) +- [#7622](https://github.com/apache/incubator-superset/pull/7622) [requirements] Bumping pydruid version (#7622) (@john-bodley) +- [#7624](https://github.com/apache/incubator-superset/pull/7624) [SQL Lab] Prevent failed query error from disappearing (#7624) (@etr2460) +- [#7628](https://github.com/apache/incubator-superset/pull/7628) [SQL Lab] Old query showing success state but not showing results (#7628) (@graceguo-supercat) +- [#7583](https://github.com/apache/incubator-superset/pull/7583) Update bug_report.md (#7583) (@john-bodley) +- [#7630](https://github.com/apache/incubator-superset/pull/7630) fix: handle presto columns with whitespace (#7630) (@khtruong) +- [#7625](https://github.com/apache/incubator-superset/pull/7625) View Presto row and array objects clearly in the data grid (#7625) (@khtruong) +- [#7627](https://github.com/apache/incubator-superset/pull/7627) Show expanded columns in gray in SQL Editor (#7627) (@betodealmeida) +- [#7525](https://github.com/apache/incubator-superset/pull/7525) Add relative start param for time filters (#7525) (@villebro) +- [#7594](https://github.com/apache/incubator-superset/pull/7594) [SQL Lab] fix unnecessary offline action (#7594) (@graceguo-supercat) +- [#7615](https://github.com/apache/incubator-superset/pull/7615) Fix SQL Lab window resizing layout bug (#7615) (@etr2460) +- [#7131](https://github.com/apache/incubator-superset/pull/7131) Make timestamp expression native SQLAlchemy element (#7131) (@villebro) +- [#6610](https://github.com/apache/incubator-superset/pull/6610) Add support for Apache Drill (#6610) (@cgivre) +- [#7550](https://github.com/apache/incubator-superset/pull/7550) Bump python libs, address insecure releases (#7550) (@mistercrunch) +- [#7579](https://github.com/apache/incubator-superset/pull/7579) Add "Auto" option to Mapbox visualization point radius (#7579) (@ali-bahjati) +- [#7379](https://github.com/apache/incubator-superset/pull/7379) Remove the use of Pandas' iloc() in WorldMapViz (#7379) (@elukey) +- [#7453](https://github.com/apache/incubator-superset/pull/7453) Add support for period character in table names (#7453) (@villebro) +- [#7586](https://github.com/apache/incubator-superset/pull/7586) Remove aggregates from metric options if datasource has no columns (#7586) (@michellethomas) -### 0.29.0rc7 (2018/12/05 14:18:19 +00:00) -- [#6464](https://github.com/apache/incubator-superset/pull/6464) Update `@superset-ui/colors` (#6464)(@kristw) +### 0.32.0rc2.dev2 (2019/05/24 03:28 +00:00) +- [#7498](https://github.com/apache/incubator-superset/pull/7498) [sql lab]revert #4833 (#7498) (@graceguo-supercat) +- [#7576](https://github.com/apache/incubator-superset/pull/7576) add American Express to list of users on readme (#7576) (@TheLastSultan) +- [#7584](https://github.com/apache/incubator-superset/pull/7584) Add link to scheduled pipeline (#7584) (@betodealmeida) +- [#7559](https://github.com/apache/incubator-superset/pull/7559) Fix for polling queries (#7559) (@betodealmeida) +- [#7585](https://github.com/apache/incubator-superset/pull/7585) A few improvements to scheduling queries (#7585) (@betodealmeida) +- [#7468](https://github.com/apache/incubator-superset/pull/7468) Adding controls for verifying options (#7468) (@michellethomas) +- [#7570](https://github.com/apache/incubator-superset/pull/7570) [testconn] Explicit closing engine connection (#7570) (@john-bodley) +- [#7573](https://github.com/apache/incubator-superset/pull/7573) [ad-hoc] Fixing type for count distinct (#7573) (@john-bodley) +- [#7552](https://github.com/apache/incubator-superset/pull/7552) [cypress] fix accessing a cross-origin frame error (#7552) (@graceguo-supercat) +- [#7330](https://github.com/apache/incubator-superset/pull/7330) Add dotenv to dependencies (#7330) (@mistercrunch) +- [#5096](https://github.com/apache/incubator-superset/pull/5096) Boxplot should not require a datetime column (#5096) (@AxelMathei) +- [#7355](https://github.com/apache/incubator-superset/pull/7355) [security] New, deprecate merge_perm, FAB method is fixed (#7355) (@dpgaspar) +- [#7426](https://github.com/apache/incubator-superset/pull/7426) Rjurney master docs update (#7426) (@rjurney) +- [#7535](https://github.com/apache/incubator-superset/pull/7535) Disabling flask-talisman by default (#7535) (@mistercrunch) +- [#7556](https://github.com/apache/incubator-superset/pull/7556) feat: add header tooltip (#7556) (@khtruong) -### 0.29.0rc6 (2018/12/05 11:27:10 +00:00) -- [#](https://github.com/apache/incubator-superset/pull/) Pypi has a 60mb package size limit, and we're overNone (#)(@mistercrunch) +### 0.33.0rc1 (2019/05/18 19:51 +00:00) +- [#7545](https://github.com/apache/incubator-superset/pull/7545) Show scheduled queries (#7545) (@betodealmeida) +- [#7544](https://github.com/apache/incubator-superset/pull/7544) Validate start/end when scheduling queries (#7544) (@betodealmeida) +- [#7529](https://github.com/apache/incubator-superset/pull/7529) Talisman config (#7529) (@craig-rueda) +- [#7523](https://github.com/apache/incubator-superset/pull/7523) [sql lab] Fix new query stuck at pending state (#7523) (@graceguo-supercat) +- [#7499](https://github.com/apache/incubator-superset/pull/7499) chore: Truncate progressbar percentage decimals (#7499) (#7517) (#7519) (@bearcage) +- [#7461](https://github.com/apache/incubator-superset/pull/7461) feat: Live query validation in the SQL Lab UI (#7461) (#7516) (#7518) (@bearcage) +- [#7507](https://github.com/apache/incubator-superset/pull/7507) fix: cache issue for api/v1/query (#7507) (@conglei) +- [#7506](https://github.com/apache/incubator-superset/pull/7506) Change Visual Properties tab label to Customize (#7506) (@felixcodes) +- [#7500](https://github.com/apache/incubator-superset/pull/7500) Flatten legacy preset charts (#7500) (@felixcodes) +- [#7443](https://github.com/apache/incubator-superset/pull/7443) [security] Adding Flask-Talisman (#7443) (@john-bodley) +- [#7485](https://github.com/apache/incubator-superset/pull/7485) Break line before LIMIT statement to prevent trailing comment issue (#7485) (@mistercrunch) +- [#7481](https://github.com/apache/incubator-superset/pull/7481) Add Chinese translation (#7481) (@cscainiao) +- [#7377](https://github.com/apache/incubator-superset/pull/7377) druid connector: avoid using 'dimensions' for scan queries (#7377) (@elukey) +- [#7464](https://github.com/apache/incubator-superset/pull/7464) Revised Chinese translation (#7464) (@cscainiao) +- [#7428](https://github.com/apache/incubator-superset/pull/7428) Refactor ConsoleLog (#7428) (@betodealmeida) +- [#7476](https://github.com/apache/incubator-superset/pull/7476) fix: alter sql columns to long text #7463 (#7476) (@khtruong) +- [#7233](https://github.com/apache/incubator-superset/pull/7233) [dashboard] After update filter, trigger new queries when charts are visible (#7233) (@graceguo-supercat) +- [#7297](https://github.com/apache/incubator-superset/pull/7297) bugfix: Improve support for special characters in schema and table names (#7297) (@villebro) +- [#7375](https://github.com/apache/incubator-superset/pull/7375) fix: calendar heatmap examples (#7375) (@mistercrunch) +- [#7471](https://github.com/apache/incubator-superset/pull/7471) Late import for optional lib pyhive (#7471) (@mistercrunch) +- [#7452](https://github.com/apache/incubator-superset/pull/7452) Adds missing metric sum__SP_RUR_TOTL (#7452) (@rjurney) +- [#7422](https://github.com/apache/incubator-superset/pull/7422) feat: Add `validate_sql_json` endpoint for checking that a given sql query is valid for the chosen database (#7422) (#7462) (@bearcage) +- [#7416](https://github.com/apache/incubator-superset/pull/7416) feat: Scheduling queries from SQL Lab (#7416) (#7446) (@DiggidyDave) +- [#7445](https://github.com/apache/incubator-superset/pull/7445) feat: view presto row objects in data grid (#7445) (@khtruong) +- [#7434](https://github.com/apache/incubator-superset/pull/7434) Quick fix to address deadlock issue (#7434) (@craig-rueda) +- [#7402](https://github.com/apache/incubator-superset/pull/7402) add chinese translate (#7402) (@cscainiao) +- [#7374](https://github.com/apache/incubator-superset/pull/7374) [fix] Fixing SQL parsing issue (#7374) (@john-bodley) +- [#6604](https://github.com/apache/incubator-superset/pull/6604) Added additional German translations to string file (#6604) (@KilimAnnejaro) +- [#7427](https://github.com/apache/incubator-superset/pull/7427) Fixes dashboard export button missing download and #7353 (#7427) (@rjurney) +- [#7421](https://github.com/apache/incubator-superset/pull/7421) Removed --console-log and superset runserver (#7421) (@rjurney) +- [#7413](https://github.com/apache/incubator-superset/pull/7413) feature: see Presto row and array data types (#7413) (@DiggidyDave) +- [#7350](https://github.com/apache/incubator-superset/pull/7350) Refactor out controlUtils.js module + unit tests (#7350) (@mistercrunch) +- [#7410](https://github.com/apache/incubator-superset/pull/7410) Setting renderTrigger on label_colors (#7410) (@michellethomas) +- [#7326](https://github.com/apache/incubator-superset/pull/7326) [annotations] Improves UX on annotation validation, start_dttm, end_dttm (#7326) (@dpgaspar) +- [#7323](https://github.com/apache/incubator-superset/pull/7323) Bump FAB to 2.0.0 (#7323) (@dpgaspar) +- [#7411](https://github.com/apache/incubator-superset/pull/7411) [SQL Lab] Increase timeout threshold for offline check (#7411) (@graceguo-supercat) +- [#7390](https://github.com/apache/incubator-superset/pull/7390) [dashboard] allow user re-order top-level tabs (#7390) (@graceguo-supercat) +- [#7407](https://github.com/apache/incubator-superset/pull/7407) Added living goods as among the users of Superset (#7407) (@chelule) +- [#7365](https://github.com/apache/incubator-superset/pull/7365) Fix NoneType bug & fill the test recipients with original recipients if empty (#7365) (@tssujt) +- [929fb6b](https://github.com/apache/incubator-superset/commit/929fb6bbb8fdc5c03ba4f88898c91183ab2bad11) Merge branch 'lyftga' (@mistercrunch) +- [#5453](https://github.com/apache/incubator-superset/pull/5453) [schema] Updating the base metric schema (#5453) (@john-bodley) +- [#7181](https://github.com/apache/incubator-superset/pull/7181) Store last selected dashboard in sessionStorage (#7181) (@leakingoxide) +- [#7371](https://github.com/apache/incubator-superset/pull/7371) [schema] Adding commits and removing unnecessary foreign-key definitions (#7371) (@john-bodley) +- [#7360](https://github.com/apache/incubator-superset/pull/7360) SUPERSET-8: Update text in docs copyright footer (#7360) (@andrewmusselman) +- [#7359](https://github.com/apache/incubator-superset/pull/7359) SUPERSET-7: Docker compose config version breaks on Ubuntu 16.04 (#7359) (@andrewmusselman) +- [#7087](https://github.com/apache/incubator-superset/pull/7087) [bubbles] issue when using duplicated metrics (#7087) (@mistercrunch) +- [#7331](https://github.com/apache/incubator-superset/pull/7331) remove backendSync.json (#7331) (@kristw) +- [#7338](https://github.com/apache/incubator-superset/pull/7338) Fix raw HTML in SliceAdder (#7338) (@mistercrunch) +- [#7348](https://github.com/apache/incubator-superset/pull/7348) Feature flag for client cache (#7348) (@betodealmeida) +- [#7361](https://github.com/apache/incubator-superset/pull/7361) Update 937d04c16b64_update_datasources.py (#7361) (@john-bodley) +- [#5452](https://github.com/apache/incubator-superset/pull/5452) [schema] Updating the base column schema (#5452) (@john-bodley) +- [#7342](https://github.com/apache/incubator-superset/pull/7342) Add type anno (#7342) (@craig-rueda) +- [#7358](https://github.com/apache/incubator-superset/pull/7358) limit tables/views returned if schema is not provided (#7358) (@datability-io) +- [#5451](https://github.com/apache/incubator-superset/pull/5451) [schema] Updating the datasources schema (#5451) (@john-bodley) +- [#7084](https://github.com/apache/incubator-superset/pull/7084) [wtforms] Strip leading/trailing whitespace (#7084) (@john-bodley) +- [#7347](https://github.com/apache/incubator-superset/pull/7347) fix: do not save colors without a color scheme (#7347) (@khtruong) +- [#7341](https://github.com/apache/incubator-superset/pull/7341) Create issue_label_bot.yaml (#7341) (@hamelsmu) +- [#7345](https://github.com/apache/incubator-superset/pull/7345) improve not rich tooltip (#7345) (@datability-io) +- [#6936](https://github.com/apache/incubator-superset/pull/6936) Allow Gamma and Alpha to access '/users/userinfo/' (#6936) (@mistercrunch) +- [#7013](https://github.com/apache/incubator-superset/pull/7013) [table] highlight selected s (#7013) (@mistercrunch) +- [#7335](https://github.com/apache/incubator-superset/pull/7335) fixes #6353 by changing tag on base image (#7335) (@connor924) +- [#7076](https://github.com/apache/incubator-superset/pull/7076) Fix #7056 'Unhashable type' in paired t-test chart (#7076) (@mistercrunch) +- [#7329](https://github.com/apache/incubator-superset/pull/7329) [docs] improve the RELEASING.md docs (#7329) (@mistercrunch) -### 0.29.0rc5 (2018/12/01 12:39:20 +00:00) -- [#6422](https://github.com/apache/incubator-superset/pull/6422) [logging] Add render failure error into log (#6422)(@graceguo-supercat) -- [#6417](https://github.com/apache/incubator-superset/pull/6417) [bugfix] Display raw value in addition to ERROR (#6417)(@kristw) -- [#6405](https://github.com/apache/incubator-superset/pull/6405) [fix] view results in sql lab (#6405)(@graceguo-supercat) -- [#6363](https://github.com/apache/incubator-superset/pull/6363) [bugfix] deck.gl grid&hex don't respond to zoom&drag (#6363)(@mistercrunch) -- [#6399](https://github.com/apache/incubator-superset/pull/6399) Fix adhoc metrics in Polygon (#6399)(@mistercrunch) -- [#6400](https://github.com/apache/incubator-superset/pull/6400) Set default limit on creation of new qe and on run (#6400)(@jeffreythewang) -- [#6393](https://github.com/apache/incubator-superset/pull/6393) [fix] JS error after delete row level tab (#6393)(@graceguo-supercat) -- [#6386](https://github.com/apache/incubator-superset/pull/6386) [bugfix] prevent d3-format from raising (#6386)(@mistercrunch) -- [#6384](https://github.com/apache/incubator-superset/pull/6384) do not convert value to lowercase when looking up color (#6384)(@kristw) -- [#6375](https://github.com/apache/incubator-superset/pull/6375) Fixed the cache issue for BigNumber (#6375)(@conglei) +### 0.32.0rc2 (2019/04/19 22:08 +00:00) +- [#7313](https://github.com/apache/incubator-superset/pull/7313) filter out all nan series (#7313) (@datability-io) +- [5f28027](https://github.com/apache/incubator-superset/commit/5f28027ce745dfda67e18fe7df8468184400be50) Merging lyftga into master (@mistercrunch) -### 0.29.0rc4 (2018/11/12 10:54:56 +00:00) -- [#6355](https://github.com/apache/incubator-superset/pull/6355) [404] Aborting for views with invalid dashboard/slice IDs (#6355)(@john-bodley) -- [#6357](https://github.com/apache/incubator-superset/pull/6357) [hive] Fixing where lastest partition logic (#6357)(@john-bodley) -- [#6361](https://github.com/apache/incubator-superset/pull/6361) [cypress] Test dashboard save/save_as functions (#6361)(@graceguo-supercat) -- [#6234](https://github.com/apache/incubator-superset/pull/6234) [reviewable] Integrate @superset-ui/{core,color,chart} modules (#6234)(@kristw) -- [#6282](https://github.com/apache/incubator-superset/pull/6282) [nvd3] refactor margins (#6282)(@mistercrunch) -- [#6359](https://github.com/apache/incubator-superset/pull/6359) Parse datasource_id as integer on the server side (#6359)(@xtinec) +### 0.32.0rc1 (2019/04/19 05:26 +00:00) +- [#7161](https://github.com/apache/incubator-superset/pull/7161) fix: typos in translations placeholders (#7161) (@leakingoxide) +- [#7231](https://github.com/apache/incubator-superset/pull/7231) Fix control validation handling (#7231) (@mistercrunch) +- [#7234](https://github.com/apache/incubator-superset/pull/7234) Adding permission for can_only_access_owned_queries (#7234) (@michellethomas) +- [#7289](https://github.com/apache/incubator-superset/pull/7289) fix: propagate color mapping from dashboard to charts (#7289) (@khtruong) +- [#7318](https://github.com/apache/incubator-superset/pull/7318) Remove LICENSE entry around dataset (#7318) (@mistercrunch) +- [#7294](https://github.com/apache/incubator-superset/pull/7294) feat: bump superset-ui versions to 0.11 (#7294) (@kristw) +- [#7314](https://github.com/apache/incubator-superset/pull/7314) [load_examples] download data at runtime (#7314) (@mistercrunch) +- [#7302](https://github.com/apache/incubator-superset/pull/7302) fix: time series table (#7302) (#7312) (@michellethomas) +- [#7315](https://github.com/apache/incubator-superset/pull/7315) Update AceEditorWrapper.jsx (#7315) (@ddna1021) +- [#7113](https://github.com/apache/incubator-superset/pull/7113) [slice] Fix, remove duplicate label_columns property (#7113) (@dpgaspar) +- [#7302](https://github.com/apache/incubator-superset/pull/7302) fix: time series table (#7302) (@khtruong) +- [#6959](https://github.com/apache/incubator-superset/pull/6959) Revert "bugfix: improve 'Time Table' (#6959)" (#7304) (@khtruong) +- [#7296](https://github.com/apache/incubator-superset/pull/7296) Add details to release instructions (#7296) (@mistercrunch) +- [#7271](https://github.com/apache/incubator-superset/pull/7271) Add all database access permission to 'Alpha' role (#7271) (@mistercrunch) +- [#7293](https://github.com/apache/incubator-superset/pull/7293) chore: update legacy packages (#7293) (@khtruong) +- [#7292](https://github.com/apache/incubator-superset/pull/7292) Bump nvd3 dep and 'npm audit fix' (#7292) (@mistercrunch) +- [#6959](https://github.com/apache/incubator-superset/pull/6959) bugfix: improve 'Time Table' (#6959) (@mistercrunch) +- [#7261](https://github.com/apache/incubator-superset/pull/7261) Minor improvements to component (#7261) (@mistercrunch) +- [#7100](https://github.com/apache/incubator-superset/pull/7100) Improve code smell, use py3k super() call (#7100) (@zhaoyongjie) +- [#7279](https://github.com/apache/incubator-superset/pull/7279) fix: make the bot more descriptive (#7279) (@kristw) +- [#7278](https://github.com/apache/incubator-superset/pull/7278) fix: make SIPs exempt from stale bots (#7278) (@kristw) +- [#7211](https://github.com/apache/incubator-superset/pull/7211) Deprecate npm run backend-sync and related logic (#7211) (@mistercrunch) +- [#7249](https://github.com/apache/incubator-superset/pull/7249) chore: add bot config files and update issue templates (#7249) (@kristw) +- [#7263](https://github.com/apache/incubator-superset/pull/7263) Run 'npm audit fix' to address vulnerabilities (#7263) (@mistercrunch) +- [#7268](https://github.com/apache/incubator-superset/pull/7268) chore: update big number package (#7268) (@khtruong) +- [#7266](https://github.com/apache/incubator-superset/pull/7266) Do not add tag to non-saved objects (#7266) (@betodealmeida) +- [#7121](https://github.com/apache/incubator-superset/pull/7121) [SQL Lab] fix table metadata loading spinner (#7121) (@mistercrunch) +- [#7009](https://github.com/apache/incubator-superset/pull/7009) Revert "Fix issues around Database permissions (#7009)" (#7267) (@betodealmeida) +- [#7264](https://github.com/apache/incubator-superset/pull/7264) Add extra bucket when max outside range (#7264) (@betodealmeida) +- [#7260](https://github.com/apache/incubator-superset/pull/7260) Bump pydruid to 0.5.2 (#7260) (@betodealmeida) +- [#7258](https://github.com/apache/incubator-superset/pull/7258) update migration Revision for #6945 (#7258) (@graceguo-supercat) +- [#7255](https://github.com/apache/incubator-superset/pull/7255) Pass viz type to GET requests (#7255) (@betodealmeida) +- [#7256](https://github.com/apache/incubator-superset/pull/7256) fix: Handle rendering a single point (#7256) (@khtruong) +- [#6964](https://github.com/apache/incubator-superset/pull/6964) feat(dashboard): direct link to single chart/tab/header in dashboard (#6964) (@graceguo-supercat) +- [#6945](https://github.com/apache/incubator-superset/pull/6945) add parent ids into Dashboard layout metadata (#6945) (@graceguo-supercat) +- [#7164](https://github.com/apache/incubator-superset/pull/7164) [cache] Render label when cached (#7164) (@john-bodley) +- [#7217](https://github.com/apache/incubator-superset/pull/7217) fix: Remove ASF license from github templates (PR and issues) (#7217) (@mistercrunch) +- [#7248](https://github.com/apache/incubator-superset/pull/7248) Fix refresh frequency (#7248) (@betodealmeida) +- [#7227](https://github.com/apache/incubator-superset/pull/7227) Improve cache (#7227) (@betodealmeida) +- [#7251](https://github.com/apache/incubator-superset/pull/7251) Add link to documentation (#7251) (@betodealmeida) +- [#7250](https://github.com/apache/incubator-superset/pull/7250) Fix partition query in Presto (#7250) (@betodealmeida) +- [#7105](https://github.com/apache/incubator-superset/pull/7105) Fix logo / branding files (#7105) (@mistercrunch) +- [#7247](https://github.com/apache/incubator-superset/pull/7247) Fix spinning in Welcome page (#7247) (@betodealmeida) +- [#7245](https://github.com/apache/incubator-superset/pull/7245) increment version numbers (#7245) (@datability-io) +- [#7212](https://github.com/apache/incubator-superset/pull/7212) Tweaks to word cloud controls (#7212) (@mistercrunch) +- [#7220](https://github.com/apache/incubator-superset/pull/7220) [filter_box] allow empty filters list (#7220) (#7244) (@michellethomas) +- [#7198](https://github.com/apache/incubator-superset/pull/7198) Fix race condition when fetching results in SQL Lab (#7198) (#7242) (@michellethomas) +- [#7240](https://github.com/apache/incubator-superset/pull/7240) Fix for tagging backend (#7240) (@betodealmeida) +- [#7232](https://github.com/apache/incubator-superset/pull/7232) increment version number for nvd3 (#7232) (@datability-io) +- [#7220](https://github.com/apache/incubator-superset/pull/7220) [filter_box] allow empty filters list (#7220) (@mistercrunch) +- [#7221](https://github.com/apache/incubator-superset/pull/7221) fix: give a more accurate time (#7221) (@khtruong) +- [#7228](https://github.com/apache/incubator-superset/pull/7228) Fix time grain after revert (#7228) (@betodealmeida) +- [#7226](https://github.com/apache/incubator-superset/pull/7226) fix: add check for polygon tooltips (#7226) (@khtruong) +- [#7148](https://github.com/apache/incubator-superset/pull/7148) Celery task for warming up cache (#7148) (@betodealmeida) +- [#7206](https://github.com/apache/incubator-superset/pull/7206) feat: [lyftga] add tooltips to deck.gl viz types (#7206) (@khtruong) +- [e714dc1](https://github.com/apache/incubator-superset/commit/e714dc19feb42fefbc573272edc06a50963b0849) Merge branch 'master' into lyftga (@mistercrunch) +- [#7215](https://github.com/apache/incubator-superset/pull/7215) Fix