From 73cc938358e139d179c14561ed0a05cc4b7b1391 Mon Sep 17 00:00:00 2001 From: Evan Rusackas Date: Tue, 10 Nov 2020 17:20:31 -0800 Subject: [PATCH] style: various little tweaks to home screen stylin' (#11650) * adding bottom padding * making light gray backgrounds match * vertical centering of empty state content. * linting :sparkles: * fixing card radii * fixing corner radius... thumb was covering corner border. --- superset-frontend/src/components/ListViewCard/index.tsx | 2 ++ superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx | 4 ++-- superset-frontend/src/views/CRUD/welcome/EmptyState.tsx | 3 +++ superset-frontend/stylesheets/less/variables.less | 2 +- 4 files changed, 8 insertions(+), 3 deletions(-) diff --git a/superset-frontend/src/components/ListViewCard/index.tsx b/superset-frontend/src/components/ListViewCard/index.tsx index 5a159235e0..5280c3d6d9 100644 --- a/superset-frontend/src/components/ListViewCard/index.tsx +++ b/superset-frontend/src/components/ListViewCard/index.tsx @@ -37,6 +37,8 @@ const ActionsWrapper = styled.div` const StyledCard = styled(Card)` border: 1px solid #d9dbe4; + border-radius: ${({ theme }) => theme.gridUnit}px; + overflow: hidden; .ant-card-body { padding: ${({ theme }) => theme.gridUnit * 4}px diff --git a/superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx b/superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx index 28d3cb9c53..9dada34dda 100644 --- a/superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx +++ b/superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx @@ -68,8 +68,8 @@ const ActivityContainer = styled.div` } grid-gap: ${({ theme }) => theme.gridUnit * 8}px; justify-content: left; - padding: ${({ theme }) => theme.gridUnit * 2}px - ${({ theme }) => theme.gridUnit * 4}px; + padding: ${({ theme }) => theme.gridUnit * 6}px; + padding-top: ${({ theme }) => theme.gridUnit * 2}px; .ant-card-meta-avatar { margin-top: ${({ theme }) => theme.gridUnit * 3}px; margin-left: ${({ theme }) => theme.gridUnit * 2}px; diff --git a/superset-frontend/src/views/CRUD/welcome/EmptyState.tsx b/superset-frontend/src/views/CRUD/welcome/EmptyState.tsx index 045ce7152b..f6dea83cf0 100644 --- a/superset-frontend/src/views/CRUD/welcome/EmptyState.tsx +++ b/superset-frontend/src/views/CRUD/welcome/EmptyState.tsx @@ -29,6 +29,9 @@ interface EmptyStateProps { } const EmptyContainer = styled.div` min-height: 200px; + display: flex; + flex-direction: column; + justify-content: space-around; `; const ButtonContainer = styled.div` Button { diff --git a/superset-frontend/stylesheets/less/variables.less b/superset-frontend/stylesheets/less/variables.less index f47d0f9f14..52974c3e02 100644 --- a/superset-frontend/stylesheets/less/variables.less +++ b/superset-frontend/stylesheets/less/variables.less @@ -49,7 +49,7 @@ @gray-dark: #484848; @gray-light: #cfd8dc; @gray: #879399; -@gray-bg: #f5f5f5; +@gray-bg: #f7f7f7; @gray-heading: #a3a3a3; @menu-hover: #f2f3f5; @lightest: #ffffff;