From 6cf698cc6a8150017eab8b5ea3c43eb1d046dd5f Mon Sep 17 00:00:00 2001 From: Erik Ritter Date: Mon, 12 Oct 2020 17:31:56 -0700 Subject: [PATCH] chore: deprecate REDUCE_DASHBOARD_BOOTSTRAP_PAYLOAD (#11244) --- UPDATING.md | 2 ++ superset/config.py | 11 +++++------ superset/views/core.py | 2 -- 3 files changed, 7 insertions(+), 8 deletions(-) diff --git a/UPDATING.md b/UPDATING.md index 26e4f6fadf..a36788c0f6 100644 --- a/UPDATING.md +++ b/UPDATING.md @@ -23,6 +23,8 @@ assists people when migrating to a new version. ## Next +* [11244](https://github.com/apache/incubator-superset/pull/11244): The `REDUCE_DASHBOARD_BOOTSTRAP_PAYLOAD` feature flag has been removed after being set to True for multiple months. + * [11172](https://github.com/apache/incubator-superset/pull/11172): Breaking change: SQL templating is turned off be default. To turn it on set `ENABLE_TEMPLATE_PROCESSING` to True on `DEFAULT_FEATURE_FLAGS` * [11155](https://github.com/apache/incubator-superset/pull/11155): The `FAB_UPDATE_PERMS` config parameter is no longer required as the Superset application correctly informs FAB under which context permissions should be updated. diff --git a/superset/config.py b/superset/config.py index 90b7613965..dce21360ea 100644 --- a/superset/config.py +++ b/superset/config.py @@ -302,7 +302,6 @@ DEFAULT_FEATURE_FLAGS: Dict[str, bool] = { "PRESTO_EXPAND_DATA": False, # Exposes API endpoint to compute thumbnails "THUMBNAILS": False, - "REDUCE_DASHBOARD_BOOTSTRAP_PAYLOAD": True, "REMOVE_SLICE_LEVEL_LABEL_COLORS": False, "SHARE_QUERIES_VIA_KV_STORE": False, "SIP_38_VIZ_REARCHITECTURE": False, @@ -628,11 +627,11 @@ UPLOADED_CSV_HIVE_NAMESPACE: Optional[str] = None # db configuration and a result of this function. # mypy doesn't catch that if case ensures list content being always str -ALLOWED_USER_CSV_SCHEMA_FUNC: Callable[ - ["Database", "models.User"], List[str] -] = lambda database, user: [ - UPLOADED_CSV_HIVE_NAMESPACE -] if UPLOADED_CSV_HIVE_NAMESPACE else [] +ALLOWED_USER_CSV_SCHEMA_FUNC: Callable[["Database", "models.User"], List[str]] = ( + lambda database, user: [UPLOADED_CSV_HIVE_NAMESPACE] + if UPLOADED_CSV_HIVE_NAMESPACE + else [] +) # Values that should be treated as nulls for the csv uploads. CSV_DEFAULT_NA_NAMES = list(STR_NA_VALUES) diff --git a/superset/views/core.py b/superset/views/core.py index e998bcbf23..fd62a0e012 100755 --- a/superset/views/core.py +++ b/superset/views/core.py @@ -1626,8 +1626,6 @@ class Superset(BaseSupersetView): # pylint: disable=too-many-public-methods # Filter out unneeded fields from the datasource payload datasources_payload = { datasource.uid: datasource.data_for_slices(slices) - if is_feature_enabled("REDUCE_DASHBOARD_BOOTSTRAP_PAYLOAD") - else datasource.data for datasource, slices in datasources.items() }