From 66e2807009a46476d2417463f5a0a2abbeb1c39b Mon Sep 17 00:00:00 2001 From: Jack <41238731+fisjac@users.noreply.github.com> Date: Wed, 30 Aug 2023 12:35:21 -0500 Subject: [PATCH] feat: removing renderCard from Tags/index.tsc to remove cardview from Tags ListView (#25105) --- superset-frontend/src/pages/Tags/index.tsx | 34 +--------------------- 1 file changed, 1 insertion(+), 33 deletions(-) diff --git a/superset-frontend/src/pages/Tags/index.tsx b/superset-frontend/src/pages/Tags/index.tsx index fa623f03c5..bbd79d0e75 100644 --- a/superset-frontend/src/pages/Tags/index.tsx +++ b/superset-frontend/src/pages/Tags/index.tsx @@ -16,7 +16,7 @@ * specific language governing permissions and limitations * under the License. */ -import React, { useMemo, useCallback, useState } from 'react'; +import React, { useMemo, useState } from 'react'; import { isFeatureEnabled, FeatureFlag, t } from '@superset-ui/core'; import { createFetchRelated, @@ -40,7 +40,6 @@ import { Link } from 'react-router-dom'; import { deleteTags } from 'src/features/tags/tags'; import { Tag as AntdTag } from 'antd'; import { Tag } from 'src/views/CRUD/types'; -import TagCard from 'src/features/tags/TagCard'; import TagModal from 'src/features/tags/TagModal'; import FaveStar from 'src/components/FaveStar'; @@ -297,36 +296,6 @@ function TagList(props: TagListProps) { }, ]; - const renderCard = useCallback( - (tag: Tag) => ( - - ), - [ - addDangerToast, - addSuccessToast, - bulkSelectEnabled, - hasPerm, - loading, - userId, - refreshData, - userKey, - ], - ); - const subMenuButtons: SubMenuProps['buttons'] = []; if (canDelete) { @@ -400,7 +369,6 @@ function TagList(props: TagListProps) { ? userKey.thumbnails : isFeatureEnabled(FeatureFlag.THUMBNAILS) } - renderCard={renderCard} defaultViewMode={ isFeatureEnabled(FeatureFlag.LISTVIEWS_DEFAULT_CARD_VIEW) ? 'card'