From 5f14b559e214b994a28cca1df33b7e475988b17a Mon Sep 17 00:00:00 2001 From: Kim Truong <47833996+khtruong@users.noreply.github.com> Date: Mon, 22 Apr 2019 15:46:24 -0700 Subject: [PATCH] fix: do not save colors without a color scheme (#7347) --- superset/assets/src/dashboard/components/Header.jsx | 2 +- superset/assets/src/dashboard/components/SaveModal.jsx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/superset/assets/src/dashboard/components/Header.jsx b/superset/assets/src/dashboard/components/Header.jsx index 92d3b1df62..8f3f831e3f 100644 --- a/superset/assets/src/dashboard/components/Header.jsx +++ b/superset/assets/src/dashboard/components/Header.jsx @@ -222,7 +222,7 @@ class Header extends React.PureComponent { colorScheme, colorNamespace, ); - const labelColors = scale.getColorMap(); + const labelColors = colorScheme ? scale.getColorMap() : {}; const data = { positions, expanded_slices: expandedSlices, diff --git a/superset/assets/src/dashboard/components/SaveModal.jsx b/superset/assets/src/dashboard/components/SaveModal.jsx index 1873f0c313..d926bc8aa5 100644 --- a/superset/assets/src/dashboard/components/SaveModal.jsx +++ b/superset/assets/src/dashboard/components/SaveModal.jsx @@ -110,7 +110,7 @@ class SaveModal extends React.PureComponent { colorScheme, colorNamespace, ); - const labelColors = scale.getColorMap(); + const labelColors = colorScheme ? scale.getColorMap() : {}; const data = { positions, css,