From 52ad779a2705c828bab3fbf38aa8b16a21a74d00 Mon Sep 17 00:00:00 2001 From: Evan Rusackas Date: Mon, 12 Jul 2021 23:43:53 -0600 Subject: [PATCH] fix: safe removal of tab with filters still scoped to a non-existing chart (#15650) --- .../src/dashboard/util/activeAllDashboardFilters.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/superset-frontend/src/dashboard/util/activeAllDashboardFilters.ts b/superset-frontend/src/dashboard/util/activeAllDashboardFilters.ts index 2243c25d56..7b9dc10a4a 100644 --- a/superset-frontend/src/dashboard/util/activeAllDashboardFilters.ts +++ b/superset-frontend/src/dashboard/util/activeAllDashboardFilters.ts @@ -104,7 +104,7 @@ export const getAllActiveFilters = ({ }; // Iterate over all roots to find all affected charts scope.rootPath.forEach((layoutItemId: string | number) => { - layout[layoutItemId].children.forEach((child: string) => { + layout[layoutItemId]?.children?.forEach((child: string) => { // Need exclude from affected charts, charts that located in scope `excluded` findAffectedCharts({ child,