From 51c3b7156c67e6545b329e95c722036158f6ac02 Mon Sep 17 00:00:00 2001
From: Victor Malai <malai9696@gmail.com>
Date: Thu, 17 Dec 2020 09:44:58 +0200
Subject: [PATCH] chore: Remove unused CodeModal (#11972)

* Transform code modal to tsx

* Fix

* Fix

* Remove unused modal

Co-authored-by: Victor Malai <victormalai@Victors-MacBook-Pro.local>
---
 .../dashboard/components/CodeModal_spec.jsx   | 39 -----------
 .../src/dashboard/components/CodeModal.jsx    | 68 -------------------
 2 files changed, 107 deletions(-)
 delete mode 100644 superset-frontend/spec/javascripts/dashboard/components/CodeModal_spec.jsx
 delete mode 100644 superset-frontend/src/dashboard/components/CodeModal.jsx

diff --git a/superset-frontend/spec/javascripts/dashboard/components/CodeModal_spec.jsx b/superset-frontend/spec/javascripts/dashboard/components/CodeModal_spec.jsx
deleted file mode 100644
index 52239a60de..0000000000
--- a/superset-frontend/spec/javascripts/dashboard/components/CodeModal_spec.jsx
+++ /dev/null
@@ -1,39 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-import React from 'react';
-import { mount } from 'enzyme';
-import { supersetTheme, ThemeProvider } from '@superset-ui/core';
-
-import CodeModal from 'src/dashboard/components/CodeModal';
-
-describe('CodeModal', () => {
-  const mockedProps = {
-    triggerNode: <i className="fa fa-edit" />,
-  };
-  it('is valid', () => {
-    expect(React.isValidElement(<CodeModal {...mockedProps} />)).toBe(true);
-  });
-  it('renders the trigger node', () => {
-    const wrapper = mount(<CodeModal {...mockedProps} />, {
-      wrappingComponent: ThemeProvider,
-      wrappingComponentProps: { theme: supersetTheme },
-    });
-    expect(wrapper.find('.fa-edit')).toExist();
-  });
-});
diff --git a/superset-frontend/src/dashboard/components/CodeModal.jsx b/superset-frontend/src/dashboard/components/CodeModal.jsx
deleted file mode 100644
index 0fab40b77d..0000000000
--- a/superset-frontend/src/dashboard/components/CodeModal.jsx
+++ /dev/null
@@ -1,68 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-import React from 'react';
-import PropTypes from 'prop-types';
-import { t } from '@superset-ui/core';
-
-import ModalTrigger from '../../components/ModalTrigger';
-
-const propTypes = {
-  triggerNode: PropTypes.node.isRequired,
-  code: PropTypes.string,
-  codeCallback: PropTypes.func,
-};
-
-const defaultProps = {
-  codeCallback: () => {},
-  code: '',
-};
-
-export default class CodeModal extends React.PureComponent {
-  constructor(props) {
-    super(props);
-    this.state = { code: props.code };
-    this.beforeOpen = this.beforeOpen.bind(this);
-  }
-
-  beforeOpen() {
-    let { code } = this.props;
-    if (!code && this.props.codeCallback) {
-      code = this.props.codeCallback();
-    }
-    this.setState({ code });
-  }
-
-  render() {
-    return (
-      <ModalTrigger
-        triggerNode={this.props.triggerNode}
-        isButton
-        beforeOpen={this.beforeOpen}
-        modalTitle={t('Active Dashboard Filters')}
-        modalBody={
-          <div className="CodeModal">
-            <pre>{this.state.code}</pre>
-          </div>
-        }
-      />
-    );
-  }
-}
-CodeModal.propTypes = propTypes;
-CodeModal.defaultProps = defaultProps;