From 473a69a7048719d706307fe7d6906026e68d427f Mon Sep 17 00:00:00 2001 From: Kamil Gabryjelski Date: Tue, 28 Feb 2023 20:15:56 +0100 Subject: [PATCH] fix(dashboard): Don't show cross filters checkbox to users without write permissions (#23237) --- .../nativeFilters/FilterBar/FilterBarSettings/index.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBarSettings/index.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBarSettings/index.tsx index dda3b7e47b..75572d74e5 100644 --- a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBarSettings/index.tsx +++ b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBarSettings/index.tsx @@ -144,7 +144,7 @@ const FilterBarSettings = () => { ); const menuItems: DropDownSelectableProps['menuItems'] = []; - if (isCrossFiltersFeatureEnabled) { + if (isCrossFiltersFeatureEnabled && canEdit) { menuItems.unshift({ key: crossFiltersMenuKey, label: crossFiltersMenuItem,