From 3fd0ba7b04a3309cc02769dbd48a698279463e95 Mon Sep 17 00:00:00 2001 From: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com> Date: Thu, 8 Sep 2022 05:43:16 -0500 Subject: [PATCH] test: Fix act errors in SaveDatasetActionButton test (#21362) --- .../SaveDatasetActionButton.test.tsx | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/superset-frontend/src/SqlLab/components/SaveDatasetActionButton/SaveDatasetActionButton.test.tsx b/superset-frontend/src/SqlLab/components/SaveDatasetActionButton/SaveDatasetActionButton.test.tsx index d6e0d7aa6c..316404e3e4 100644 --- a/superset-frontend/src/SqlLab/components/SaveDatasetActionButton/SaveDatasetActionButton.test.tsx +++ b/superset-frontend/src/SqlLab/components/SaveDatasetActionButton/SaveDatasetActionButton.test.tsx @@ -29,7 +29,7 @@ const overlayMenu = ( ); describe('SaveDatasetActionButton', () => { - it('renders a split save button', () => { + test('renders a split save button', async () => { render( true} @@ -40,11 +40,14 @@ describe('SaveDatasetActionButton', () => { const saveBtn = screen.getByRole('button', { name: /save/i }); const caretBtn = screen.getByRole('button', { name: /caret-down/i }); + expect( + await screen.findByRole('button', { name: /save/i }), + ).toBeInTheDocument(); expect(saveBtn).toBeVisible(); expect(caretBtn).toBeVisible(); }); - it('renders a "save dataset" dropdown menu item when user clicks caret button', () => { + test('renders a "save dataset" dropdown menu item when user clicks caret button', async () => { render( true} @@ -53,6 +56,9 @@ describe('SaveDatasetActionButton', () => { ); const caretBtn = screen.getByRole('button', { name: /caret-down/i }); + expect( + await screen.findByRole('button', { name: /caret-down/i }), + ).toBeInTheDocument(); userEvent.click(caretBtn); const saveDatasetMenuItem = screen.getByText(/save dataset/i);