From 3cd16cf3680169dd17a542d83c84f94ca8220805 Mon Sep 17 00:00:00 2001
From: Denny Biasiolli <dennybiasiolli@users.noreply.github.com>
Date: Sun, 30 Apr 2017 19:58:09 +0200
Subject: [PATCH] Fix test's warnings (#2697)

* tests: adding required props to FilterableTable mockedProps

* tests: adding required prop `height` to QuerySearch mockedProps

* tests: adding required prop `height` to ResultSet mockedProps

* tests: adding required prop `height` to SqlEditorLeftBar mockedProps

* tests: fix warning in Timer component
---
 .../FilterableTable/FilterableTable_spec.jsx           |  7 ++++++-
 .../spec/javascripts/sqllab/QuerySearch_spec.jsx       |  1 +
 .../assets/spec/javascripts/sqllab/ResultSet_spec.jsx  | 10 +++-------
 .../spec/javascripts/sqllab/SqlEditorLeftBar_spec.jsx  |  1 +
 superset/assets/spec/javascripts/sqllab/Timer_spec.jsx |  5 +----
 5 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/superset/assets/spec/javascripts/components/FilterableTable/FilterableTable_spec.jsx b/superset/assets/spec/javascripts/components/FilterableTable/FilterableTable_spec.jsx
index f0de6f7ce2..240a8e499a 100644
--- a/superset/assets/spec/javascripts/components/FilterableTable/FilterableTable_spec.jsx
+++ b/superset/assets/spec/javascripts/components/FilterableTable/FilterableTable_spec.jsx
@@ -4,7 +4,12 @@ import { expect } from 'chai';
 import FilterableTable from '../../../../javascripts/components/FilterableTable/FilterableTable';
 
 describe('FilterableTable', () => {
+  const mockedProps = {
+    orderedColumnKeys: [],
+    data: [],
+    height: 0,
+  };
   it('is valid element', () => {
-    expect(React.isValidElement(<FilterableTable />)).to.equal(true);
+    expect(React.isValidElement(<FilterableTable {...mockedProps} />)).to.equal(true);
   });
 });
diff --git a/superset/assets/spec/javascripts/sqllab/QuerySearch_spec.jsx b/superset/assets/spec/javascripts/sqllab/QuerySearch_spec.jsx
index be0bbebb8d..e68ebd0622 100644
--- a/superset/assets/spec/javascripts/sqllab/QuerySearch_spec.jsx
+++ b/superset/assets/spec/javascripts/sqllab/QuerySearch_spec.jsx
@@ -11,6 +11,7 @@ import QuerySearch from '../../../javascripts/SqlLab/components/QuerySearch';
 describe('QuerySearch', () => {
   const mockedProps = {
     actions: {},
+    height: 0,
   };
   it('is valid', () => {
     expect(
diff --git a/superset/assets/spec/javascripts/sqllab/ResultSet_spec.jsx b/superset/assets/spec/javascripts/sqllab/ResultSet_spec.jsx
index 3c46aa2f9e..7e5cd15c77 100644
--- a/superset/assets/spec/javascripts/sqllab/ResultSet_spec.jsx
+++ b/superset/assets/spec/javascripts/sqllab/ResultSet_spec.jsx
@@ -9,14 +9,10 @@ import { queries } from './fixtures';
 describe('ResultSet', () => {
   const mockedProps = {
     query: queries[0],
+    height: 0,
   };
-  it('renders', () => {
-    expect(React.isValidElement(<ResultSet />)).to.equal(true);
-  });
-  it('renders with props', () => {
-    expect(
-      React.isValidElement(<ResultSet />),
-    ).to.equal(true);
+  it('is valid', () => {
+    expect(React.isValidElement(<ResultSet {...mockedProps} />)).to.equal(true);
   });
   it('renders a Table', () => {
     const wrapper = shallow(<ResultSet {...mockedProps} />);
diff --git a/superset/assets/spec/javascripts/sqllab/SqlEditorLeftBar_spec.jsx b/superset/assets/spec/javascripts/sqllab/SqlEditorLeftBar_spec.jsx
index 42fcd14c6b..c20c1a6cb9 100644
--- a/superset/assets/spec/javascripts/sqllab/SqlEditorLeftBar_spec.jsx
+++ b/superset/assets/spec/javascripts/sqllab/SqlEditorLeftBar_spec.jsx
@@ -12,6 +12,7 @@ describe('SqlEditorLeftBar', () => {
   const mockedProps = {
     tables: [table],
     queryEditor: defaultQueryEditor,
+    height: 0,
   };
   it('is valid', () => {
     expect(
diff --git a/superset/assets/spec/javascripts/sqllab/Timer_spec.jsx b/superset/assets/spec/javascripts/sqllab/Timer_spec.jsx
index 4d62a7ae11..9bad34c32e 100644
--- a/superset/assets/spec/javascripts/sqllab/Timer_spec.jsx
+++ b/superset/assets/spec/javascripts/sqllab/Timer_spec.jsx
@@ -14,10 +14,7 @@ describe('Timer', () => {
     isRunning: true,
     state: 'warning',
   };
-  it('renders', () => {
-    expect(React.isValidElement(<Timer />)).to.equal(true);
-  });
-  it('renders with props', () => {
+  it('is valid', () => {
     expect(React.isValidElement(<Timer {...mockedProps} />))
     .to.equal(true);
   });