From 36fda5e840addd20fd37b9e70061b7bf91744c86 Mon Sep 17 00:00:00 2001 From: Geido <60598000+geido@users.noreply.github.com> Date: Mon, 1 Mar 2021 20:28:32 +0200 Subject: [PATCH] test: FormLabel dedicated directory and tests (#13270) * Form label directory and tests * Fix linting * Remove unnecessary data-test-id --- .../components/FormLabel/FormLabel.test.tsx | 52 +++++++++++++++++++ .../{FormLabel.tsx => FormLabel/index.tsx} | 0 2 files changed, 52 insertions(+) create mode 100644 superset-frontend/src/components/FormLabel/FormLabel.test.tsx rename superset-frontend/src/components/{FormLabel.tsx => FormLabel/index.tsx} (100%) diff --git a/superset-frontend/src/components/FormLabel/FormLabel.test.tsx b/superset-frontend/src/components/FormLabel/FormLabel.test.tsx new file mode 100644 index 0000000000..0f901785e2 --- /dev/null +++ b/superset-frontend/src/components/FormLabel/FormLabel.test.tsx @@ -0,0 +1,52 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import React from 'react'; +import { render, screen } from 'spec/helpers/testing-library'; +import { FormControl } from 'react-bootstrap'; +import FormLabel from './index'; + +const mockedProps = { + children: 'Form label', + required: false, + htmlFor: 'form-control', +}; + +test('should render', () => { + const { container } = render(); + expect(container).toBeInTheDocument(); +}); + +test('should render a Label', () => { + render( + <> + + + , + ); + expect(screen.getByLabelText('Form label')).toBeInTheDocument(); +}); + +test('should be shown as required', () => { + const requiredProps = { + ...mockedProps, + required: true, + }; + render(); + expect(screen.getByText('*').parentNode).toBeInTheDocument(); +}); diff --git a/superset-frontend/src/components/FormLabel.tsx b/superset-frontend/src/components/FormLabel/index.tsx similarity index 100% rename from superset-frontend/src/components/FormLabel.tsx rename to superset-frontend/src/components/FormLabel/index.tsx