From 35d9cb38a80849cd90524a2dfa3995490e219940 Mon Sep 17 00:00:00 2001 From: "JUST.in DO IT" Date: Fri, 7 Oct 2022 11:11:04 -0700 Subject: [PATCH] fix(explore): chart link is broken without localStorage (#21707) --- superset-frontend/src/explore/ExplorePage.tsx | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/superset-frontend/src/explore/ExplorePage.tsx b/superset-frontend/src/explore/ExplorePage.tsx index 7f5be7e5e4..c8d4138ce4 100644 --- a/superset-frontend/src/explore/ExplorePage.tsx +++ b/superset-frontend/src/explore/ExplorePage.tsx @@ -101,7 +101,7 @@ const getDashboardContextFormData = () => { Object.assign(dashboardContextWithFilters, { dashboardId }); return dashboardContextWithFilters; } - return {}; + return null; }; export default function ExplorePage() { @@ -117,10 +117,12 @@ export default function ExplorePage() { if (!isExploreInitialized.current || isSaveAction) { fetchExploreData(exploreUrlParams) .then(({ result }) => { - const formData = getFormDataWithDashboardContext( - result.form_data, - dashboardContextFormData, - ); + const formData = dashboardContextFormData + ? getFormDataWithDashboardContext( + result.form_data, + dashboardContextFormData, + ) + : result.form_data; dispatch( hydrateExplore({ ...result,