From 3035090915bcca6afd96856f3ceb515d437f6cb3 Mon Sep 17 00:00:00 2001
From: Kasia Kucharczyk <2536609+kkucharc@users.noreply.github.com>
Date: Tue, 1 Dec 2020 19:43:50 +0100
Subject: [PATCH] fix: filters push out apply button on dashboard (#11580)

* Changed height of slices in dashboard into 100%-padding, so there is no scroll appearing anymore

* Added scroll to the block on dashboard, when filters are too high

* Applied lint
---
 superset-frontend/src/components/Select/OnPasteSelect.jsx | 8 +++++++-
 .../src/dashboard/components/gridComponents/Chart.jsx     | 2 +-
 .../src/dashboard/stylesheets/components/chart.less       | 5 +++++
 3 files changed, 13 insertions(+), 2 deletions(-)

diff --git a/superset-frontend/src/components/Select/OnPasteSelect.jsx b/superset-frontend/src/components/Select/OnPasteSelect.jsx
index e7d08aea0a..5fcd597858 100644
--- a/superset-frontend/src/components/Select/OnPasteSelect.jsx
+++ b/superset-frontend/src/components/Select/OnPasteSelect.jsx
@@ -76,7 +76,13 @@ export default class OnPasteSelect extends React.Component {
 
   render() {
     const { selectWrap: SelectComponent, ...restProps } = this.props;
-    return <SelectComponent {...restProps} onPaste={this.onPaste} />;
+    return (
+      <SelectComponent
+        {...restProps}
+        onPaste={this.onPaste}
+        menuPortalTarget={document.body}
+      />
+    );
   }
 }
 
diff --git a/superset-frontend/src/dashboard/components/gridComponents/Chart.jsx b/superset-frontend/src/dashboard/components/gridComponents/Chart.jsx
index e42c259288..ef162cc044 100644
--- a/superset-frontend/src/dashboard/components/gridComponents/Chart.jsx
+++ b/superset-frontend/src/dashboard/components/gridComponents/Chart.jsx
@@ -269,7 +269,7 @@ export default class Chart extends React.Component {
       : {};
 
     return (
-      <div>
+      <div className="chart-slice">
         <SliceHeader
           innerRef={this.setHeaderRef}
           slice={slice}
diff --git a/superset-frontend/src/dashboard/stylesheets/components/chart.less b/superset-frontend/src/dashboard/stylesheets/components/chart.less
index ebf2e93559..e245049b8d 100644
--- a/superset-frontend/src/dashboard/stylesheets/components/chart.less
+++ b/superset-frontend/src/dashboard/stylesheets/components/chart.less
@@ -23,6 +23,7 @@
   background-color: @lightest;
   position: relative;
   padding: 16px;
+  overflow-y: auto;
 
   // transitionable traits for when a filter is being actively focused
   transition: opacity 0.2s, border-color 0.2s, box-shadow 0.2s;
@@ -112,6 +113,10 @@
   }
 }
 
+.chart-slice {
+  height: calc(100% - 32px);
+}
+
 .dot {
   @dot-diameter: 4px;