diff --git a/superset/assets/javascripts/explorev2/components/ChartContainer.jsx b/superset/assets/javascripts/explorev2/components/ChartContainer.jsx index 0917d57126..904b16f1b8 100644 --- a/superset/assets/javascripts/explorev2/components/ChartContainer.jsx +++ b/superset/assets/javascripts/explorev2/components/ChartContainer.jsx @@ -144,6 +144,32 @@ class ChartContainer extends React.Component { return title; } + renderChart() { + if (this.props.alert) { + return ( + + {this.props.alert} + + + ); + } + if (this.props.isChartLoading) { + return (loading); + } + return ( +
{ this.chartContainerRef = ref; }} + className={this.props.viz_type} + style={{ 'overflow-x': 'scroll' }} + /> + ); + } + render() { return (
@@ -187,26 +213,7 @@ class ChartContainer extends React.Component {
} > - {this.props.alert && - - {this.props.alert} - - - } - {this.props.isChartLoading ? - (loading) - : - (
{ this.chartContainerRef = ref; }} - className={this.props.viz_type} - style={{ 'overflow-x': 'scroll' }} - />) - } + {this.renderChart()}
); diff --git a/superset/assets/javascripts/explorev2/components/ExploreViewContainer.jsx b/superset/assets/javascripts/explorev2/components/ExploreViewContainer.jsx index 6d79f8a8f6..ce44b11ee0 100644 --- a/superset/assets/javascripts/explorev2/components/ExploreViewContainer.jsx +++ b/superset/assets/javascripts/explorev2/components/ExploreViewContainer.jsx @@ -33,12 +33,10 @@ class ExploreViewContainer extends React.Component { } componentWillReceiveProps(nextProps) { - let refreshChart = false; - autoQueryFields.forEach((field) => { - if (nextProps.form_data[field] !== this.props.form_data[field]) { - refreshChart = true; - } - }); + const refreshChart = Object.keys(nextProps.form_data).some((field) => ( + nextProps.form_data[field] !== this.props.form_data[field] + && autoQueryFields.indexOf(field) !== -1) + ); if (refreshChart) { this.onQuery(nextProps.form_data); } diff --git a/superset/assets/javascripts/explorev2/stores/store.js b/superset/assets/javascripts/explorev2/stores/store.js index 0c02435bc0..817602d020 100644 --- a/superset/assets/javascripts/explorev2/stores/store.js +++ b/superset/assets/javascripts/explorev2/stores/store.js @@ -1748,4 +1748,27 @@ export function initialState(vizType = 'table', datasourceType = 'table') { export const autoQueryFields = [ 'datasource', 'viz_type', + 'bar_stacked', + 'show_markers', + 'show_bar_value', + 'order_bars', + 'show_controls', + 'reduce_x_ticks', + 'include_series', + 'pie_label_type', + 'show_brush', + 'include_search', + 'show_bubbles', + 'show_legend', + 'x_axis_showminmax', + 'rich_tooltip', + 'y_axis_zero', + 'y_log_scale', + 'x_log_scale', + 'donut', + 'labels_outside', + 'contribution', + 'size', + 'row_limit', + 'max_bubble_size', ];