From 25188c42e0eb988650b900cb88cb51dc41ae0047 Mon Sep 17 00:00:00 2001
From: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Date: Thu, 8 Sep 2022 15:39:35 -0500
Subject: [PATCH] test: Fix act errors in SubMenu test (#21387)
---
.../src/views/components/SubMenu.test.tsx | 28 ++++++++++---------
1 file changed, 15 insertions(+), 13 deletions(-)
diff --git a/superset-frontend/src/views/components/SubMenu.test.tsx b/superset-frontend/src/views/components/SubMenu.test.tsx
index 6359e03cc2..6365f9a8c6 100644
--- a/superset-frontend/src/views/components/SubMenu.test.tsx
+++ b/superset-frontend/src/views/components/SubMenu.test.tsx
@@ -45,7 +45,7 @@ const mockedProps = {
],
dropDownLinks: [
{
- label: 'test a upload',
+ label: 'test an upload',
childs: [
{
label: 'Upload Test',
@@ -58,29 +58,31 @@ const mockedProps = {
],
};
-test('should render', () => {
+test('should render', async () => {
const { container } = render();
+ expect(await screen.findByText(/title/i)).toBeInTheDocument();
expect(container).toBeInTheDocument();
});
-test('should render the navigation', () => {
+test('should render the navigation', async () => {
render();
- expect(screen.getByRole('navigation')).toBeInTheDocument();
+ expect(await screen.findByRole('navigation')).toBeInTheDocument();
});
-test('should render the brand', () => {
+test('should render the brand', async () => {
render();
- expect(screen.getByText('Title')).toBeInTheDocument();
+ expect(await screen.findByText('Title')).toBeInTheDocument();
});
-test('should render the right number of tabs', () => {
+test('should render the right number of tabs', async () => {
render();
- expect(screen.getAllByRole('tab')).toHaveLength(3);
+ expect(await screen.findAllByRole('tab')).toHaveLength(3);
});
-test('should render all the tabs links', () => {
+test('should render all the tabs links', async () => {
const { tabs } = mockedProps;
render();
+ expect(await screen.findAllByRole('tab')).toHaveLength(3);
tabs.forEach(tab => {
const tabItem = screen.getByText(tab.label);
expect(tabItem).toHaveAttribute('href', tab.url);
@@ -89,12 +91,12 @@ test('should render all the tabs links', () => {
test('should render dropdownlinks', async () => {
render();
- userEvent.hover(screen.getByText('test a upload'));
- const label = await screen.findByText('test a upload');
+ userEvent.hover(screen.getByText('test an upload'));
+ const label = await screen.findByText('test an upload');
expect(label).toBeInTheDocument();
});
-test('should render the buttons', () => {
+test('should render the buttons', async () => {
const mockFunc = jest.fn();
const buttons = [
{
@@ -114,7 +116,7 @@ test('should render the buttons', () => {
};
render();
const testButton = screen.getByText(buttons[0].name);
- expect(screen.getAllByRole('button')).toHaveLength(3);
+ expect(await screen.findAllByRole('button')).toHaveLength(3);
userEvent.click(testButton);
expect(mockFunc).toHaveBeenCalled();
});