From 234a139fb27dd89af1803db4b1721f7fd02b87f2 Mon Sep 17 00:00:00 2001 From: Jongwoo Han Date: Fri, 1 Mar 2024 00:16:20 +0900 Subject: [PATCH] chore: Replace deprecated command with environment file (#27304) --- scripts/tag_latest_release.sh | 12 ++++++------ tests/unit_tests/scripts/tag_latest_release_test.py | 4 ++-- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/scripts/tag_latest_release.sh b/scripts/tag_latest_release.sh index 58f192039b..b57c67e25f 100755 --- a/scripts/tag_latest_release.sh +++ b/scripts/tag_latest_release.sh @@ -98,13 +98,13 @@ done if [ -z "${GITHUB_TAG_NAME}" ]; then echo "Missing tag parameter, usage: ./scripts/tag_latest_release.sh " - echo "::set-output name=SKIP_TAG::true" + echo "SKIP_TAG=true" >> $GITHUB_OUTPUT exit 1 fi if [ -z "$(git_show_ref)" ]; then echo "The tag ${GITHUB_TAG_NAME} does not exist. Please use a different tag." - echo "::set-output name=SKIP_TAG::true" + echo "SKIP_TAG=true" >> $GITHUB_OUTPUT exit 0 fi @@ -112,7 +112,7 @@ fi if ! [[ ${GITHUB_TAG_NAME} =~ ^[0-9]+\.[0-9]+\.[0-9]+$ ]] then echo "This tag ${GITHUB_TAG_NAME} is not a valid release version. Not tagging." - echo "::set-output name=SKIP_TAG::true" + echo "SKIP_TAG=true" >> $GITHUB_OUTPUT exit 1 fi @@ -177,14 +177,14 @@ done # Determine the result based on the comparison if [[ -z "$compare_result" ]]; then echo "Versions are equal" - echo "::set-output name=SKIP_TAG::true" + echo "SKIP_TAG=true" >> $GITHUB_OUTPUT elif [[ "$compare_result" == "greater" ]]; then echo "This release tag ${GITHUB_TAG_NAME} is newer than the latest." - echo "::set-output name=SKIP_TAG::false" + echo "SKIP_TAG=false" >> $GITHUB_OUTPUT # Add other actions you want to perform for a newer version elif [[ "$compare_result" == "lesser" ]]; then echo "This release tag ${GITHUB_TAG_NAME} is older than the latest." echo "This release tag ${GITHUB_TAG_NAME} is not the latest. Not tagging." # if you've gotten this far, then we don't want to run any tags in the next step - echo "::set-output name=SKIP_TAG::true" + echo "SKIP_TAG=true" >> $GITHUB_OUTPUT fi diff --git a/tests/unit_tests/scripts/tag_latest_release_test.py b/tests/unit_tests/scripts/tag_latest_release_test.py index 6dbb0eee4e..eebd316db3 100644 --- a/tests/unit_tests/scripts/tag_latest_release_test.py +++ b/tests/unit_tests/scripts/tag_latest_release_test.py @@ -33,7 +33,7 @@ def wrapped(*args, **kwargs): "tag, expected_output", [ ("1.0.0", "This release tag 1.0.0 is older than the latest."), - ("2.1.0", "Versions are equal\n::set-output name=SKIP_TAG::true"), + ("2.1.0", "Versions are equal\n"), ("2.1.1", "This release tag 2.1.1 is newer than the latest."), ("3.0.0", "This release tag 3.0.0 is newer than the latest."), ("2.1.0rc1", "This tag 2.1.0rc1 is not a valid release version. Not tagging."), @@ -44,7 +44,7 @@ def wrapped(*args, **kwargs): ("2.1", "This tag 2.1 is not a valid release version. Not tagging."), ( "does_not_exist", - "The tag does_not_exist does not exist. Please use a different tag.\n::set-output name=SKIP_TAG::true", + "The tag does_not_exist does not exist. Please use a different tag.\n", ), ], )