diff --git a/superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx b/superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx index 06a0cb349c..3522f6e1b6 100644 --- a/superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx +++ b/superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx @@ -1532,6 +1532,69 @@ const DatabaseModal: FunctionComponent = ({ ); + const renderDatabaseConnectionForm = () => ( + <> + { + setDB({ type: ActionType.addTableCatalogSheet }); + }} + onQueryChange={({ target }: { target: HTMLInputElement }) => + onChange(ActionType.queryChange, { + name: target.name, + value: target.value, + }) + } + onExtraInputChange={({ target }: { target: HTMLInputElement }) => + onChange(ActionType.extraInputChange, { + name: target.name, + value: target.value, + }) + } + onRemoveTableCatalog={(idx: number) => { + setDB({ + type: ActionType.removeTableCatalogSheet, + payload: { indexToDelete: idx }, + }); + }} + onParametersChange={({ target }: { target: HTMLInputElement }) => + onChange(ActionType.parametersChange, { + type: target.type, + name: target.name, + checked: target.checked, + value: target.value, + }) + } + onChange={({ target }: { target: HTMLInputElement }) => + onChange(ActionType.textChange, { + name: target.name, + value: target.value, + }) + } + getValidation={() => getValidation(db)} + validationErrors={validationErrors} + getPlaceholder={getPlaceholder} + /> + + + + {useSSHTunneling && ( + {renderSSHTunnelForm()} + )} + + ); + const renderFinishState = () => { if (!editNewDb) { return ( @@ -1568,51 +1631,7 @@ const DatabaseModal: FunctionComponent = ({ /> ); } - return ( - - onChange(ActionType.parametersChange, { - type: target.type, - name: target.name, - checked: target.checked, - value: target.value, - }) - } - onExtraInputChange={({ target }: { target: HTMLInputElement }) => - onChange(ActionType.extraInputChange, { - name: target.name, - value: target.value, - }) - } - onChange={({ target }: { target: HTMLInputElement }) => - onChange(ActionType.textChange, { - name: target.name, - value: target.value, - }) - } - onQueryChange={({ target }: { target: HTMLInputElement }) => - onChange(ActionType.queryChange, { - name: target.name, - value: target.value, - }) - } - onAddTableCatalog={() => - setDB({ type: ActionType.addTableCatalogSheet }) - } - onRemoveTableCatalog={(idx: number) => - setDB({ - type: ActionType.removeTableCatalogSheet, - payload: { indexToDelete: idx }, - }) - } - getValidation={() => getValidation(db)} - validationErrors={validationErrors} - /> - ); + return renderDatabaseConnectionForm(); }; if ( @@ -1758,49 +1777,7 @@ const DatabaseModal: FunctionComponent = ({ )} ) : ( - - onChange(ActionType.parametersChange, { - type: target.type, - name: target.name, - checked: target.checked, - value: target.value, - }) - } - onExtraInputChange={({ target }: { target: HTMLInputElement }) => - onChange(ActionType.extraInputChange, { - name: target.name, - value: target.value, - }) - } - onChange={({ target }: { target: HTMLInputElement }) => - onChange(ActionType.textChange, { - name: target.name, - value: target.value, - }) - } - onQueryChange={({ target }: { target: HTMLInputElement }) => - onChange(ActionType.queryChange, { - name: target.name, - value: target.value, - }) - } - onAddTableCatalog={() => - setDB({ type: ActionType.addTableCatalogSheet }) - } - onRemoveTableCatalog={(idx: number) => - setDB({ - type: ActionType.removeTableCatalogSheet, - payload: { indexToDelete: idx }, - }) - } - getValidation={() => getValidation(db)} - validationErrors={validationErrors} - /> + renderDatabaseConnectionForm() )} {!isEditMode && ( @@ -1950,73 +1927,7 @@ const DatabaseModal: FunctionComponent = ({ dbModel={dbModel} /> {hasAlert && renderStepTwoAlert()} - { - setDB({ type: ActionType.addTableCatalogSheet }); - }} - onQueryChange={({ target }: { target: HTMLInputElement }) => - onChange(ActionType.queryChange, { - name: target.name, - value: target.value, - }) - } - onExtraInputChange={({ - target, - }: { - target: HTMLInputElement; - }) => - onChange(ActionType.extraInputChange, { - name: target.name, - value: target.value, - }) - } - onRemoveTableCatalog={(idx: number) => { - setDB({ - type: ActionType.removeTableCatalogSheet, - payload: { indexToDelete: idx }, - }); - }} - onParametersChange={({ - target, - }: { - target: HTMLInputElement; - }) => - onChange(ActionType.parametersChange, { - type: target.type, - name: target.name, - checked: target.checked, - value: target.value, - }) - } - onChange={({ target }: { target: HTMLInputElement }) => - onChange(ActionType.textChange, { - name: target.name, - value: target.value, - }) - } - getValidation={() => getValidation(db)} - validationErrors={validationErrors} - getPlaceholder={getPlaceholder} - /> - - - - {useSSHTunneling && ( - - {renderSSHTunnelForm()} - - )} + {renderDatabaseConnectionForm()}
infoTooltip(theme)}> {dbModel.engine !== Engines.GSheet && ( <>