From 213b772368b6301571b3ae3e2c17d03adb9c287b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=CA=88=E1=B5=83=E1=B5=A2?= Date: Thu, 17 Sep 2020 12:53:00 -0700 Subject: [PATCH] chore: remove SIP_34_DATABASE_UI (#10926) --- superset/config.py | 1 - superset/views/database/views.py | 6 +----- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/superset/config.py b/superset/config.py index 58a6b0d0cb..02070ad29f 100644 --- a/superset/config.py +++ b/superset/config.py @@ -309,7 +309,6 @@ DEFAULT_FEATURE_FLAGS: Dict[str, bool] = { "SIP_38_VIZ_REARCHITECTURE": False, "TAGGING_SYSTEM": False, "SQLLAB_BACKEND_PERSISTENCE": False, - "SIP_34_DATABASE_UI": False, } # This is merely a default. diff --git a/superset/views/database/views.py b/superset/views/database/views.py index 6987de9d54..0961381837 100644 --- a/superset/views/database/views.py +++ b/superset/views/database/views.py @@ -32,7 +32,6 @@ from superset import app, db from superset.connectors.sqla.models import SqlaTable from superset.constants import RouteMethod from superset.exceptions import CertificateException -from superset.extensions import feature_flag_manager from superset.sql_parse import Table from superset.typing import FlaskResponse from superset.utils import core as utils @@ -99,10 +98,7 @@ class DatabaseView( @expose("/list/") @has_access def list(self) -> FlaskResponse: - if not ( - app.config["ENABLE_REACT_CRUD_VIEWS"] - and feature_flag_manager.is_feature_enabled("SIP_34_DATABASE_UI") - ): + if not app.config["ENABLE_REACT_CRUD_VIEWS"]: return super().list() return super().render_app_template()