diff --git a/.github/workflows/docker.yml b/.github/workflows/docker.yml index bedf12a957..93259061ec 100644 --- a/.github/workflows/docker.yml +++ b/.github/workflows/docker.yml @@ -33,6 +33,10 @@ jobs: matrix: build_preset: ${{fromJson(needs.setup_matrix.outputs.matrix_config)}} fail-fast: false + env: + DOCKERHUB_USER: ${{ secrets.DOCKERHUB_USER }} + DOCKERHUB_TOKEN: ${{ secrets.DOCKERHUB_TOKEN }} + steps: - name: Set up QEMU @@ -41,6 +45,13 @@ jobs: - name: Set up Docker Buildx uses: docker/setup-buildx-action@v3 + - name: Try to login to DockerHub + continue-on-error: true + uses: docker/login-action@v3 + with: + username: ${{ secrets.DOCKERHUB_USER }} + password: ${{ secrets.DOCKERHUB_TOKEN }} + - name: Setup Node Env uses: actions/setup-node@v4 with: @@ -56,13 +67,7 @@ jobs: - name: Build Docker Image shell: bash - env: - DOCKERHUB_USER: ${{ secrets.DOCKERHUB_USER }} - DOCKERHUB_TOKEN: ${{ secrets.DOCKERHUB_TOKEN }} run: | - if [ -n "$DOCKERHUB_TOKEN" ]; then - docker login - fi # Single platform builds in pull_request context to speed things up if [ "${{ github.event_name }}" = "push" ]; then PLATFORM_ARG="--platform linux/arm64 --platform linux/amd64"