From 15654a3082f4d6030fafd38d671299670443374e Mon Sep 17 00:00:00 2001 From: Alanna Scott Date: Fri, 14 Apr 2017 15:35:37 -0700 Subject: [PATCH] fix filters on dashboard (#2619) --- superset/assets/javascripts/dashboard/Dashboard.jsx | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/superset/assets/javascripts/dashboard/Dashboard.jsx b/superset/assets/javascripts/dashboard/Dashboard.jsx index 1fbd72c21d..2094fb2ddc 100644 --- a/superset/assets/javascripts/dashboard/Dashboard.jsx +++ b/superset/assets/javascripts/dashboard/Dashboard.jsx @@ -190,12 +190,10 @@ export function dashboardContainer(dashboard, datasources) { if (!(sliceId in this.filters)) { this.filters[sliceId] = {}; } - if (!(col in this.filters[sliceId])) { - if (!merge) { - this.filters[sliceId][col] = vals; - } else { - this.filters[sliceId][col] = d3.merge([this.filters[sliceId][col], vals]); - } + if (!(col in this.filters[sliceId]) || !merge) { + this.filters[sliceId][col] = vals; + } else { + this.filters[sliceId][col] = d3.merge([this.filters[sliceId][col], vals]); } if (refresh) { this.refreshExcept(sliceId);