From 11562971fb95a601d11b2902f1704b72409f302d Mon Sep 17 00:00:00 2001 From: Stephen Liu <750188453@qq.com> Date: Fri, 29 Apr 2022 00:10:58 +0800 Subject: [PATCH] fix(plugin-chart-echarts): [feature parity] annotation line chart color not working (#19758) --- .../src/MixedTimeseries/transformProps.ts | 2 ++ .../plugin-chart-echarts/src/Timeseries/transformProps.ts | 2 ++ .../plugin-chart-echarts/src/Timeseries/transformers.ts | 5 ++++- 3 files changed, 8 insertions(+), 1 deletion(-) diff --git a/superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/transformProps.ts b/superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/transformProps.ts index 8ac08e3925..593ac053cc 100644 --- a/superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/transformProps.ts +++ b/superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/transformProps.ts @@ -236,6 +236,8 @@ export default function transformProps( markerSize, data1, annotationData, + colorScale, + sliceId, ), ); } diff --git a/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts b/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts index b8585c6e68..16007e1bb2 100644 --- a/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts +++ b/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts @@ -259,6 +259,8 @@ export default function transformProps( markerSize, data, annotationData, + colorScale, + sliceId, ), ); } diff --git a/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts b/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts index 7e8dbf855c..e574ad4cc7 100644 --- a/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts +++ b/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts @@ -418,9 +418,11 @@ export function transformTimeseriesAnnotation( markerSize: number, data: TimeseriesDataRecord[], annotationData: AnnotationData, + colorScale: CategoricalColorScale, + sliceId?: number, ): SeriesOption[] { const series: SeriesOption[] = []; - const { hideLine, name, opacity, showMarkers, style, width } = layer; + const { hideLine, name, opacity, showMarkers, style, width, color } = layer; const result = annotationData[name]; if (isTimeseriesAnnotationResult(result)) { result.forEach(annotation => { @@ -435,6 +437,7 @@ export function transformTimeseriesAnnotation( opacity: parseAnnotationOpacity(opacity), type: style as ZRLineType, width: hideLine ? 0 : width, + color: color || colorScale(name, sliceId), }, }); });