From 0c0666caa0e7ce5725416115389fe797113b731c Mon Sep 17 00:00:00 2001 From: Riccardo Magliocchetti Date: Mon, 3 Apr 2017 17:25:08 +0200 Subject: [PATCH] druid: use six.string_types instead of basestring (#2541) Which is not available in python3 Fix #2539 --- superset/connectors/druid/models.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/superset/connectors/druid/models.py b/superset/connectors/druid/models.py index 3bb7923cfb..e8063d3f7a 100644 --- a/superset/connectors/druid/models.py +++ b/superset/connectors/druid/models.py @@ -982,10 +982,10 @@ class DruidDatasource(Model, BaseDatasource): if op in ('in', 'not in'): eq = [ types.replace("'", '').strip() - if isinstance(types, basestring) + if isinstance(types, string_types) else types for types in eq] - elif not isinstance(flt['val'], basestring): + elif not isinstance(flt['val'], string_types): eq = eq[0] if len(eq) > 0 else '' if col in self.num_cols: if op in ('in', 'not in'):