From e3e3657f2be818e79252fcee0a385954de8d56f7 Mon Sep 17 00:00:00 2001 From: 0x08 <15280042+its0x08@users.noreply.github.com> Date: Thu, 23 May 2024 15:09:45 +0200 Subject: [PATCH] fix: Add space to fix URLs in terminal - Added space between URL and ">" character which made the link show not found page because ">" becomes part of the URL Example URLs: - https://github.com/jtesta/ssh-audit/issues> - https://github.com/jtesta/ssh-audit/issues%3E - https://www.ssh-audit.com/hardening_guides.html%3E - https://www.ssh-audit.com/hardening_guides.html> Example New URLs: - https://github.com/jtesta/ssh-audit/issues - https://www.ssh-audit.com/hardening_guides.html --- src/ssh_audit/ssh_audit.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ssh_audit/ssh_audit.py b/src/ssh_audit/ssh_audit.py index 4fff3ae..b9da314 100755 --- a/src/ssh_audit/ssh_audit.py +++ b/src/ssh_audit/ssh_audit.py @@ -456,7 +456,7 @@ def output_info(out: OutputBuffer, software: Optional['Software'], client_audit: # If any warnings or failures were given, print a link to the hardening guides. if any_problems: - out.warn('(nfo) For hardening guides on common OSes, please see: ') + out.warn('(nfo) For hardening guides on common OSes, please see: < https://www.ssh-audit.com/hardening_guides.html >') # Add any additional notes. for additional_note in additional_notes: @@ -721,7 +721,7 @@ def output(out: OutputBuffer, aconf: AuditConf, banner: Optional[Banner], header # Build & write the JSON struct. out.info(json.dumps(build_struct(aconf.host + ":" + str(aconf.port), banner, cves, kex=kex, client_host=client_host, software=software, algorithms=algs, algorithm_recommendation_suppress_list=algorithm_recommendation_suppress_list, additional_notes=additional_notes), indent=4 if aconf.json_print_indent else None, sort_keys=True)) elif len(unknown_algorithms) > 0: # If we encountered any unknown algorithms, ask the user to report them. - out.warn("\n\n!!! WARNING: unknown algorithm(s) found!: %s. Please email the full output above to the maintainer (jtesta@positronsecurity.com), or create a Github issue at .\n" % ','.join(unknown_algorithms)) + out.warn("\n\n!!! WARNING: unknown algorithm(s) found!: %s. Please email the full output above to the maintainer (jtesta@positronsecurity.com), or create a Github issue at < https://github.com/jtesta/ssh-audit/issues >.\n" % ','.join(unknown_algorithms)) return program_retval