From e2fc60cbb45f01e27a0e241d503c55e40ce36873 Mon Sep 17 00:00:00 2001 From: Joe Testa Date: Tue, 20 Jun 2023 09:26:43 -0400 Subject: [PATCH] Updated README and test for resolve function. --- README.md | 1 + test/test_resolve.py | 10 +++++----- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index fdc975e..b971220 100644 --- a/README.md +++ b/README.md @@ -180,6 +180,7 @@ For convenience, a web front-end on top of the command-line tool is available at ### v3.0.0-dev (2023-??-??) - Results from concurrent scans against multiple hosts are no longer improperly combined; bug discovered by [Adam Russell](https://github.com/thecliguy). + - Hostname resolution failure no longer causes scans against multiple hosts to terminate unexpectedly; credit [Dani Cuesta](https://github.com/daniel-cues). - Added 1 new key exchange: `curve448-sha512@libssh.org`. ### v2.9.0 (2023-04-29) diff --git a/test/test_resolve.py b/test/test_resolve.py index fbaa033..41f0c87 100644 --- a/test/test_resolve.py +++ b/test/test_resolve.py @@ -22,12 +22,12 @@ class TestResolve: vsocket.gsock.addrinfodata['localhost#22'] = socket.gaierror(8, 'hostname nor servname provided, or not known') conf = self._conf() s = self.ssh_socket(self.OutputBuffer(), 'localhost', 22, conf.ip_version_preference) - output_spy.begin() - with pytest.raises(SystemExit): + # output_spy.begin() + with pytest.raises(socket.gaierror): list(s._resolve()) - lines = output_spy.flush() - assert len(lines) == 1 - assert 'hostname nor servname provided' in lines[-1] + # lines = output_spy.flush() + # assert len(lines) == 1 + # assert 'hostname nor servname provided' in lines[-1] def test_resolve_hostname_without_records(self, output_spy, virtual_socket): vsocket = virtual_socket