From c4013d2e10c2c526e21dd0229d60ab9e6c51d252 Mon Sep 17 00:00:00 2001
From: ArabCoders <admin@arabcoders.org>
Date: Wed, 15 Nov 2023 13:55:14 +0300
Subject: [PATCH] Updated the summary and the Dto name.

---
 Emby.Server.Implementations/Library/UserDataManager.cs      | 3 +--
 Jellyfin.Api/Controllers/ItemsController.cs                 | 3 +--
 MediaBrowser.Controller/Library/IUserDataManager.cs         | 2 +-
 .../Dto/{UserDataDto.cs => UpdateUserItemDataDto.cs}        | 6 ++----
 4 files changed, 5 insertions(+), 9 deletions(-)
 rename MediaBrowser.Model/Dto/{UserDataDto.cs => UpdateUserItemDataDto.cs} (78%)

diff --git a/Emby.Server.Implementations/Library/UserDataManager.cs b/Emby.Server.Implementations/Library/UserDataManager.cs
index 585fdd4f09..8beeb8041f 100644
--- a/Emby.Server.Implementations/Library/UserDataManager.cs
+++ b/Emby.Server.Implementations/Library/UserDataManager.cs
@@ -6,7 +6,6 @@ using System;
 using System.Collections.Concurrent;
 using System.Collections.Generic;
 using System.Globalization;
-using System.Reflection;
 using System.Threading;
 using Jellyfin.Data.Entities;
 using MediaBrowser.Controller.Configuration;
@@ -82,7 +81,7 @@ namespace Emby.Server.Implementations.Library
             });
         }
 
-        public void SaveUserData(User user, BaseItem item, UserDataDto userDataDto, UserDataSaveReason reason)
+        public void SaveUserData(User user, BaseItem item, UpdateUserItemDataDto userDataDto, UserDataSaveReason reason)
         {
             ArgumentNullException.ThrowIfNull(user);
             ArgumentNullException.ThrowIfNull(item);
diff --git a/Jellyfin.Api/Controllers/ItemsController.cs b/Jellyfin.Api/Controllers/ItemsController.cs
index dd54e6ca78..ae80d15e60 100644
--- a/Jellyfin.Api/Controllers/ItemsController.cs
+++ b/Jellyfin.Api/Controllers/ItemsController.cs
@@ -1,7 +1,6 @@
 using System;
 using System.ComponentModel.DataAnnotations;
 using System.Linq;
-using System.Threading;
 using Jellyfin.Api.Extensions;
 using Jellyfin.Api.Helpers;
 using Jellyfin.Api.ModelBinders;
@@ -928,7 +927,7 @@ public class ItemsController : BaseJellyfinApiController
     public ActionResult<UserItemDataDto> UpdateItemUserData(
         [FromRoute, Required] Guid userId,
         [FromRoute, Required] Guid itemId,
-        [FromBody, Required] UserDataDto userDataDto)
+        [FromBody, Required] UpdateUserItemDataDto userDataDto)
     {
         if (!RequestHelpers.AssertCanUpdateUser(_userManager, User, userId, true))
         {
diff --git a/MediaBrowser.Controller/Library/IUserDataManager.cs b/MediaBrowser.Controller/Library/IUserDataManager.cs
index 8849c098fb..43cccfc65c 100644
--- a/MediaBrowser.Controller/Library/IUserDataManager.cs
+++ b/MediaBrowser.Controller/Library/IUserDataManager.cs
@@ -42,7 +42,7 @@ namespace MediaBrowser.Controller.Library
         /// <param name="item">The item.</param>
         /// <param name="userDataDto">The reason for updating the user data.</param>
         /// <param name="reason">The reason.</param>
-        void SaveUserData(User user, BaseItem item, UserDataDto userDataDto, UserDataSaveReason reason);
+        void SaveUserData(User user, BaseItem item, UpdateUserItemDataDto userDataDto, UserDataSaveReason reason);
 
         UserItemData GetUserData(User user, BaseItem item);
 
diff --git a/MediaBrowser.Model/Dto/UserDataDto.cs b/MediaBrowser.Model/Dto/UpdateUserItemDataDto.cs
similarity index 78%
rename from MediaBrowser.Model/Dto/UserDataDto.cs
rename to MediaBrowser.Model/Dto/UpdateUserItemDataDto.cs
index 6d8c8969b0..9ff09cb22c 100644
--- a/MediaBrowser.Model/Dto/UserDataDto.cs
+++ b/MediaBrowser.Model/Dto/UpdateUserItemDataDto.cs
@@ -1,11 +1,9 @@
 namespace MediaBrowser.Model.Dto
 {
     /// <summary>
-    /// Class UserDataDto extends UserItemDataDto to allow nullable members.
-    /// This change allow us to implement the new /Users/{UserId}/Items/{ItemId}/UserData endpoint.
-    /// This object allows the requestor to update all or specific user data fields without altering the non-nullable members state.
+    /// This is used by the api to get information about a item user data.
     /// </summary>
-    public class UserDataDto : UserItemDataDto
+    public class UpdateUserItemDataDto : UserItemDataDto
     {
         /// <summary>
         /// Gets or sets the playback position ticks.