From b9638b484ddc27de3c554ad622f1bdbdc97541de Mon Sep 17 00:00:00 2001 From: Luke Pulverenti Date: Wed, 2 Dec 2015 23:38:16 -0500 Subject: [PATCH] update interval task trigger --- .../ScheduledTasks/IntervalTrigger.cs | 38 +++++++++---------- 1 file changed, 17 insertions(+), 21 deletions(-) diff --git a/MediaBrowser.Common/ScheduledTasks/IntervalTrigger.cs b/MediaBrowser.Common/ScheduledTasks/IntervalTrigger.cs index a12fea14cd..e07dfcceb4 100644 --- a/MediaBrowser.Common/ScheduledTasks/IntervalTrigger.cs +++ b/MediaBrowser.Common/ScheduledTasks/IntervalTrigger.cs @@ -1,6 +1,7 @@ using MediaBrowser.Model.Events; using MediaBrowser.Model.Tasks; using System; +using System.Linq; using System.Threading; namespace MediaBrowser.Common.ScheduledTasks @@ -30,16 +31,7 @@ namespace MediaBrowser.Common.ScheduledTasks /// public TaskExecutionOptions TaskOptions { get; set; } - /// - /// Gets or sets the first run delay. - /// - /// The first run delay. - public TimeSpan FirstRunDelay { get; set; } - - public IntervalTrigger() - { - FirstRunDelay = TimeSpan.FromHours(1); - } + private DateTime _lastStartDate; /// /// Stars waiting for the trigger action @@ -50,20 +42,21 @@ namespace MediaBrowser.Common.ScheduledTasks { DisposeTimer(); - var triggerDate = lastResult != null ? - lastResult.EndTimeUtc.Add(Interval) : - DateTime.UtcNow.Add(FirstRunDelay); + DateTime triggerDate; + + if (lastResult == null) + { + // Task has never been completed before + triggerDate = DateTime.UtcNow.AddHours(1); + } + else + { + triggerDate = new[] { lastResult.EndTimeUtc, _lastStartDate }.Max().Add(Interval); + } if (DateTime.UtcNow > triggerDate) { - if (isApplicationStartup) - { - triggerDate = DateTime.UtcNow.AddMinutes(1); - } - else - { - triggerDate = DateTime.UtcNow.AddMinutes(1); - } + triggerDate = DateTime.UtcNow.AddMinutes(1); } Timer = new Timer(state => OnTriggered(), null, triggerDate - DateTime.UtcNow, TimeSpan.FromMilliseconds(-1)); @@ -98,8 +91,11 @@ namespace MediaBrowser.Common.ScheduledTasks /// private void OnTriggered() { + DisposeTimer(); + if (Triggered != null) { + _lastStartDate = DateTime.UtcNow; Triggered(this, new GenericEventArgs(TaskOptions)); } }