From 05c8834a3a2a51ad2c0bff355500348382697fb5 Mon Sep 17 00:00:00 2001
From: cvium <clausvium@gmail.com>
Date: Tue, 21 Dec 2021 00:10:58 +0100
Subject: [PATCH] Don't cache special feature ids

---
 .../Entities/IHasSpecialFeatures.cs           |  4 ++--
 .../Entities/Movies/Movie.cs                  | 21 ++++---------------
 2 files changed, 6 insertions(+), 19 deletions(-)

diff --git a/MediaBrowser.Controller/Entities/IHasSpecialFeatures.cs b/MediaBrowser.Controller/Entities/IHasSpecialFeatures.cs
index f317a02ff3..f47d2162f7 100644
--- a/MediaBrowser.Controller/Entities/IHasSpecialFeatures.cs
+++ b/MediaBrowser.Controller/Entities/IHasSpecialFeatures.cs
@@ -10,9 +10,9 @@ namespace MediaBrowser.Controller.Entities
     public interface IHasSpecialFeatures
     {
         /// <summary>
-        /// Gets or sets the special feature ids.
+        /// Gets the special feature ids.
         /// </summary>
         /// <value>The special feature ids.</value>
-        IReadOnlyList<Guid> SpecialFeatureIds { get; set; }
+        IReadOnlyList<Guid> SpecialFeatureIds { get; }
     }
 }
diff --git a/MediaBrowser.Controller/Entities/Movies/Movie.cs b/MediaBrowser.Controller/Entities/Movies/Movie.cs
index 6f1a0a8cfe..dfaf03fdad 100644
--- a/MediaBrowser.Controller/Entities/Movies/Movie.cs
+++ b/MediaBrowser.Controller/Entities/Movies/Movie.cs
@@ -19,24 +19,11 @@ namespace MediaBrowser.Controller.Entities.Movies
     /// </summary>
     public class Movie : Video, IHasSpecialFeatures, IHasTrailers, IHasLookupInfo<MovieInfo>, ISupportsBoxSetGrouping
     {
-        private IReadOnlyList<Guid> _specialFeatureIds;
-
         /// <inheritdoc />
-        public IReadOnlyList<Guid> SpecialFeatureIds
-        {
-            get
-            {
-                return _specialFeatureIds ??= GetExtras()
-                    .Where(extra => extra.ExtraType != Model.Entities.ExtraType.Trailer)
-                    .Select(song => song.Id)
-                    .ToArray();
-            }
-
-            set
-            {
-                _specialFeatureIds = value;
-            }
-        }
+        public IReadOnlyList<Guid> SpecialFeatureIds => GetExtras()
+            .Where(extra => extra.ExtraType != null && extra is Video)
+            .Select(extra => extra.Id)
+            .ToArray();
 
         /// <inheritdoc />
         public IReadOnlyList<BaseItem> LocalTrailers => GetExtras()